Switch Camino to getting nsIDownload.h from toolkit

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Tracking

Trunk
x86
Mac OS X
Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 287183 [details] [diff] [review]
fix

All we need from downloads is the nsIDownload header, so that's an easy way to use one less bit of xpfe. This switches what we build and include, and makes the minor changes necessary to bring us in line with the toolkit changes to nsIDownload.

mento, I have no idea if that's the best way to opt us out of that part of xpfe, so suggestions are welcome if not.
Attachment #287183 - Flags: superreview?(mark)

Comment 1

11 years ago
Comment on attachment 287183 [details] [diff] [review]
fix

>Index: toolkit/components/Makefile.in

> ifeq ($(MOZ_BUILD_APP),camino)
> DIRS += autocomplete/public
>+DIRS += downloads/public
> endif

There's no reason to have two DIRS lines here.  You can put both of these directories on the same line, or you can keep them on two lines but break them up with a \.

I can only give superreview in mozilla/camino (and I do here), but you've got non-Camino bits in this patch, so I'm marking this r=me.  Since the only non-Camino bits are build config, my review there is sufficient too, build config shouldn't require superreview.
Attachment #287183 - Flags: superreview?(mark) → review+
(Assignee)

Comment 2

11 years ago
Landed on trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Unlanded; I completely forgot things currently need approval for trunk landing :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

11 years ago
Attachment #287183 - Flags: approval1.9?
(Assignee)

Comment 4

11 years ago
Moving to Toolkit:Build Config since I'm told the approval request is unlikely to be noticed otherwise.
Assignee: stuart.morgan → nobody
Status: REOPENED → NEW
Component: Downloading → Build Config
Product: Camino → Toolkit
QA Contact: downloading → build-config
Summary: Switch to getting nsIDownload.h from toolkit → Switch Camino to getting nsIDownload.h from toolkit
Assignee: nobody → stuart.morgan

Comment 5

11 years ago
That thing about approval requests going unnoticed unless they are in certain components/products is IMHO absolutely ridiculous, but unfortunately we have it currently, yes :(
just fyi, we moved nsIDonwload to xpfe because we were changing nsIDownload, and there may be more changes down the line...

Updated

11 years ago
Attachment #287183 - Flags: approval1.9? → approval1.9+
I should rephrase what I said last time.  I won't feel bad if we break you guys on accident since you are using toolkit's nsIDownload but not the download manager backend.
(Assignee)

Comment 8

11 years ago
(In reply to comment #7)
> I won't feel bad if we break you guys on accident

Noted, but with all the eagerness to rip xpfe out of the tree, I don't see that we have a lot of choice in the short term.

Landed on trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
No longer depends on: 403724
Depends on: 403724
Component: Build Config → Downloading
Product: Toolkit → Camino
QA Contact: build-config → downloading
You need to log in before you can comment on or make changes to this bug.