Closed Bug 402302 Opened 17 years ago Closed 15 years ago

My current bookmark backups have no bookmarks toolbar folder

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: ria.klaassen, Unassigned)

References

Details

At the moment I see the items and sub folders on my bookmarks toolbar folder. 
But when I use a backup from my folder "bookmarkbackups", the whole bookmarks toolbar folder is missing, also in my menu.

I tested this a few times in a new profile. It happens also on branch, so there is something wrong with the backup. About two weeks ago it was still working well, when I deleted places.sqlite and started all over again with one of the backups. 

I couldn't reproduce the problem with an older bookmarks.html file.
Flags: blocking-firefox3?
The latest bookmark backups are only 368 kB. Should be more than 957 kB. I did a search for some BT items in the file, but without result. They are really gone.
I made a mistake in the first line of comment 0, I wrote: "At the moment I see the items and sub folders on my bookmarks toolbar folder", but I meant to say: "At the moment I see the items and sub folders on my bookmarks toolbar".

But there is no folder with the name "Bookmarks Toolbar Folder" neither in the Bookmarks menu nor in the Organizer. That is probably why this folder is not written to the bookmarks.html backup files.

So places.sqlite must have a split mind. 
Hrm, I wasn't able to reproduce this with an existing profile (the product of serial nightlies over the last few months), nor a new profile.
When I do a search in the Organizer for one of my Toolbar bookmarks e.g. called "Wrap" it hangs after "Wra" with CPU 100%. 

(In reply to comment #3)
> Hrm, I wasn't able to reproduce this with an existing profile (the product of
> serial nightlies over the last few months), nor a new profile.
>
No, I can't reproduce it either. I think it's just a corruption. Unfortunately it has chosen me to happen :(. 

I repaired one of the backups partially in a branch build and started all over again with blank history (to avoid further corruption).
I have saved the original places.sqlite in case someone wants to investigate in this, although there are no steps to reproduce, all what is visible is the result. 
Flags: blocking-firefox3?
I think BTW that this must have happened during import a few weeks ago. It has written the information to a new places.sqlite, but has obviously made a mistake. 
Grrrrrr it happened again. My new places.sqlite was only 17 days old and the bookmarks toolbar folder is gone again. This time it is different, bookmarks and folders of the BTF are still somewhere hidden in the bookmarks.html file (because it's more than 1000 kB) but the folder is not visible in the menu.
Blocks: 404871
This is not the only one:

I have the same problem for my unfiled bookmarks folder

I can't say what I have done
Also worked with places.sqlite,
Running mac OS X and Vista (same problems)
My .json backups have still no Bookmarks Toolbar folder. Strange; when I retest this with a new profile (default set of bookmarks with some new ones on the Bookmarks Toolbar) I can't reproduce it, so the problem is caused by my bookmarks file.
Ria, could you come up with a reduced bookmarks file or places.sqlite file which causes this issue? 
I'm afraid not. I don't have the places.sqlite file from comment 5 anymore; lost during a system reinstall.
Both the export function (.json) and the contents of the bookmarksbackups folder (also .json) have no bookmarks toolbar folder, but all bookmarks and folders are present in de result of "Export HTML". 
Have you tried to re-import this html file? Are you able to reproduce the issue in that way? Just an idea...
Yes, it is a perfect file. It works normally. I can import it or throw it in an empty profile and it will show all bookmarks.
When I delete everything in this profile except the bookmarkbackups folder, it will show all bookmarks after startup. So the problem is not reproducible with the HTML file.
Blocks: 444478
Ria, could you check if on the bookmarks toolbar of that file you have a place:folder=FOLDERID (FORDERID is a number).

IIRC i filed a bug (i hope) where if you have a folder shortcut to a non existing folder the toolbar comes up empty
(In reply to comment #14)
>
I see no information about this in the Library. When I open places.sqlite with a SQLite Database Browser I see something like:

root_name: toolbar
folder_id: 837
with sqlite database browser you should try executing

SELECT h.id, h.url FROM moz_places h
JOIN moz_bookmarks b ON b.fk = h.id
WHERE h.url > 'place:' AND h.url < 'place;'
AND b.parent = (SELECT folder_id FROM moz_bookmarks_roots WHERE root_name = 'toolbar')

and see if you have a place:folder=XX url
Ria, can you try the suggestion from comment #16?
No response from the reporter, so closing.  Feel free to reopen with the needed data!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INCOMPLETE
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.