402353 - print Page Setup fails with Illegal value... [nsICommandLine::handleFlagWithParam] plus Error: NSPrintSetup is not defined when invoked from 3pane or standalone mail window

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Wayne Mery (:wsmwk)]

mail window menu fails to bring up Page Setup

Error: [Exception... "'Illegal value' when calling method: [nsICommandLine::handleFlagWithParam]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///C:/Program%20Files/mozilla.org/SM%202.0a%20071022/components/nsBrowserContentHandler.js :: handle :: line 397"  data: no]
Source File: file:///C:/Program%20Files/mozilla.org/SM%202.0a%20071022/components/nsBrowserContentHandler.js
Line: 397

Error: NSPrintSetup is not defined
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 579

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102203 SeaMonkey/2.0a1pre

Comment 1

[Wayne Mery (:wsmwk)]

forgot to state, doesn't fail when invoked from browser window.

Comment 2

[Mark Banner (:standard8)]

Looks like regression from bug 387247. Page Setup in the Message Window is also broken. Patch coming up.

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix

These looked fine when I viewed them in emacs :/

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Created an attachment (id=287251) [details]
> The fix
> 
> These looked fine when I viewed them in emacs :/
(the indentation, that is)

Comment 5

[Ian Neal]

Yeah, looks good to me apart from the indentation.

Comment 6

[[e-mail]]

Comment on attachment 287251 [details] [diff] [review]
The fix

> 			case "cmd_printSetup":
>-			  NSPrintSetup();
>+                PrintUtils.showPageSetup();
> 			  return;
While you're there you might as well fix the tabs on the other two relevant lines too (I'm not one for random whitespace fixup but I figure these three lines are sufficiently related to merit it, as per the other hunk).

Comment 7

[Mark Banner (:standard8)]

Patch checked in to trunk with whitespace fixed.