402360 - Pausing downloads that haven't started shouldn't debug assert

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

We have a NS_NOTREACHED that will assert for debug builds which can cause problems with xpcshell testcases.

NS_NOTREACHED("We don't have a resumable download or a request to suspend??");

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Remove the NOTREACHED and update comments. + testcase!

But some reason it prints out other stuff before PASS..

../../../../_tests/xpcshell-simple/test_dm/unit/test_bug_402360.js: mozilla/trunk/mozilla/tools/test-harness/xpcshell-simple/test_all.sh: line 127:  1003 Abort trap              NATIVE_TOPSRCDIR="$native_topsrcdir" TOPSRCDIR="$topsrcdir" $xpcshell -s $headfiles -f $t $tailfiles 2>$t.log 1>&2
PASS

Comment 2

[Ed Lee :Mardak]

Attachment: v1.1

Actually.. throw in the test for resume for good measure.

The one iffy thing about this is that we rely on pause/resume to happen before the ProgressChange.

Comment 3

[Shawn Wilsher :sdwilsh]

yeah, that means it actually failed.  Do a check-interactive to get more output as to what's wrong.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 287239 [details] [diff] [review]
v1.1

Canceling request per comment 3

Comment 5

[Ed Lee :Mardak]

Fixed by bug 410289.