Closed Bug 402369 Opened 12 years ago Closed 12 years ago

Modify strings added in bug 401575 for SSL netError pages

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: reed, Assigned: reed)

Details

(Keywords: polish)

Attachments

(1 file, 3 obsolete files)

Attached patch patch - v1 (obsolete) — Splinter Review
A couple of miscellaneous changes to the strings added in bug 401575...

* Rename "Get Me Out of Here" to "Get me out of here!" to match what we use on the phishing/malware pages.
* Add "..." to the "Add Exception" button to match what we do on pretty much every button that opens a dialog.
* Correct a comment to be correct with the above changes.
Attachment #287240 - Flags: ui-review?(beltzner)
Attachment #287240 - Flags: review?(beltzner)
(In reply to comment #0)
> * Add "..." to the "Add Exception" button to match what we do on pretty much
> every button that opens a dialog.

See bug 401575, comment #56.
Attached patch patch - v2 (obsolete) — Splinter Review
Now that I think about it, I think the comma from securityOverride.warningText should be removed since it is a grammatical error.
Attachment #287240 - Attachment is obsolete: true
Attachment #287242 - Flags: ui-review?(beltzner)
Attachment #287242 - Flags: review?(beltzner)
Attachment #287240 - Flags: ui-review?(beltzner)
Attachment #287240 - Flags: review?(beltzner)
Component: Security → Security: UI
Product: Firefox → Core
QA Contact: firefox → ui
Hadn't we decided that we were using an ellipses, not "...", wherever possible?
Attached patch patch - v2.1 (obsolete) — Splinter Review
Changed to "Add Exception…".

What about the "Or you can add an exception..."? Should that be "…" instead of "..."?
Attachment #287242 - Attachment is obsolete: true
Attachment #287333 - Flags: ui-review?(beltzner)
Attachment #287333 - Flags: review?(beltzner)
Attachment #287242 - Flags: ui-review?(beltzner)
Attachment #287242 - Flags: review?(beltzner)
Comment on attachment 287333 [details] [diff] [review]
patch - v2.1

Yeah, the ellipses in the text should probably also be the actual character, as well. I'll trust you to change that. :)

I'm still pretty sure that I'll be filing a follow-up at some other point to change this and the malware button to use title caps, though, like every other button in our UI. And an exclamation point.

With that change, r+ui-r=beltzner
Attachment #287333 - Flags: ui-review?(beltzner)
Attachment #287333 - Flags: ui-review+
Attachment #287333 - Flags: review?(beltzner)
Attachment #287333 - Flags: review+
Comment on attachment 287333 [details] [diff] [review]
patch - v2.1

a=beltzner for M9 w/nits addressed; no l10n impact, this is english polish change only.
Attachment #287333 - Flags: approvalM9+
Attachment #287333 - Flags: approval1.9+
Attached patch what I landedSplinter Review
Attachment #287333 - Attachment is obsolete: true
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.881; previous revision: 1.880
done
Checking in browser/locales/en-US/chrome/overrides/netError.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/overrides/netError.dtd,v  <--  netError.dtd
new revision: 1.13; previous revision: 1.12
done
Checking in camino/embed-replacements/locale/en-US/global/netError.dtd;
/cvsroot/mozilla/camino/embed-replacements/locale/en-US/global/netError.dtd,v  <--  netError.dtd
new revision: 1.9; previous revision: 1.8
done
Checking in dom/locales/en-US/chrome/netError.dtd;
/cvsroot/mozilla/dom/locales/en-US/chrome/netError.dtd,v  <--  netError.dtd
new revision: 1.13; previous revision: 1.12
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.