402439 - Clipboard is emptied on application exit

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[Serge Gautherie (:sgautherie)]

Regressed between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103103 Minefield/3.0a9pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre] (nightly) (W2Ksp4)

Confirmed by
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103102 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007110103 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

My steps:
1. Start browser application.
2. Load <about:>.
3. Copy the build id "line".
4. Paste it in another app: works :-)
5. Exit browser application.
6. Paste it in another app: no more data :-(

<http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&sortby=Date&hours=2&date=explicit&mindate=2007-10-31+03&maxdate=2007-11-01+04+&cvsroot=%2Fcvsroot>
My best guess would be bug 386286.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking, but not blocking beta. Adding relnote ...

Comment 2

[Ere Maijala (slow)]

Taking.

Comment 3

[Ere Maijala (slow)]

Attachment: Patch

This should fix it. The problem was that OleUninitialize was called before the observer in nsClipboard tried to call OleFlushClipboard. I removed the observed and moved OleFlushClipboard right before OleUninitialize. The comment changes are just removed CR's.

Comment 4

[Ere Maijala (slow)]

And the CloseClipboard call in nsClipboard was superfluous.

Comment 5

[Serge Gautherie (:sgautherie)]

(Had a look at MSDN for both functions: the fix looks perfect ;-))

Comment 6

[[e-mail]]

Comment on attachment 287856 [details] [diff] [review]
Patch

>+NS_IMPL_ISUPPORTS1(nsClipboard, nsBaseClipboard)

>+  NS_DECL_ISUPPORTS

You shouldn't need these, nsBaseClipboard already provides them.
(They were there before to resolve the ambiguous nsISupports cast.)

Comment 7

[Ere Maijala (slow)]

Comment on attachment 287856 [details] [diff] [review]
Patch

Ok, I'll remove them before checking in.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Ere, jst-review takes exception to your patch as well.
http://beaufour.dk/jst-review/

Comment 9

[[e-mail]]

(In reply to comment #8)
>Ere, jst-review takes exception to your patch as well.
>http://beaufour.dk/jst-review/
That's a bug in jst-review, not in the patch.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Not the complaint about Windows line endings...

Comment 11

[Ere Maijala (slow)]

?? The patch _removes_ a couple of Windows line endigns and I can't see jst-review complaining about that.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

OK, nevermind me then :). Sorry for the spam.

Comment 13

[Reed Loden [:reed]]

Ere, think you could commit this soon? If you don't have time, just let me know, and I can check it in for you.

Comment 14

[Ere Maijala (slow)]

Fix checked in.

Comment 15

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007111403 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed.

Comment 17

[Mats Palmgren (inactive)]

FYI, this bug isn't listed in Beta 1 rel notes yet:
http://www.mozilla.com/en-US/firefox/3.0b1/releasenotes/

Comment 18

[Ere Maijala (slow)]

(In reply to comment #17)
> FYI, this bug isn't listed in Beta 1 rel notes yet:
> http://www.mozilla.com/en-US/firefox/3.0b1/releasenotes/

Is there still a reason to relnote something as this is fixed?

Comment 19

[Ria Klaassen (not reading all bugmail)]

This may be a fixed bug but I see it every day.

Comment 20

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)
> This may be a fixed bug but I see it every day.

This bug was (reported) fixed 2 years ago.
Please file a new bug, with details.