Closed Bug 402506 Opened 17 years ago Closed 17 years ago

Build failure in nsCookieService if PR_LOGGING is not defined

Categories

(Core :: Networking: Cookies, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 402395

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
If PR_LOGGING is not defined, there is an empty line before ';': > nsresult rv = InitDB(); > if (NS_FAILED(rv)) > COOKIE_LOGSTRING(PR_LOG_WARNING, ("Init(): InitDB() gave error %x", rv)); By this warning, I cannot build with VC2005 and cygwin. Should use PR_BEGIN_MACRO and PR_END_MACRO.
Flags: blocking1.9?
Attachment #287375 - Flags: superreview?(mconnor)
Attachment #287375 - Flags: review?(mconnor)
Summary: Build failure in nsCookieService if #PR_LOGGING is not defined → Build failure in nsCookieService if PR_LOGGING is not defined
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Attachment #287375 - Flags: superreview?(mconnor)
Attachment #287375 - Flags: review?(mconnor)
No longer blocks: 401998
Flags: blocking1.9?
Target Milestone: mozilla1.9 M9 → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: