Closed
Bug 402516
Opened 17 years ago
Closed 17 years ago
Remove calIOperation::success
Categories
(Calendar :: Internal Components, enhancement)
Calendar
Internal Components
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: dbo, Assigned: dbo)
Details
Attachments
(1 file)
3.69 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Follow up from bug 401861: Using calIOperation on listeners supporting multiple result calls, makes calIOperation::success obsolete.
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #287841 -
Flags: review?(philipp)
Comment 2•17 years ago
|
||
Comment on attachment 287841 [details] [diff] [review] removing Funny, I was against this in the first place ;) (In bug 329034 comment #14) >+ >+ /** >+ * Determines whether the request has succeeded, i.e. it has successfully >+ * been completed. >+ */ >+ readonly attribute boolean success; I don't think we really need success if we have isPending and status. Using (!op.isPending && Components.isSuccessCode(op.status)) should be sufficient for anyone using calIOperation. I'm fine with keeping it though.
Attachment #287841 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•17 years ago
|
||
I think it would have made sense (as a shortcut) if we really have a single response only; and that's been the consensus with lilmatt at that time. But this limits the usage too much IMHO.
Assignee | ||
Comment 4•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Assignee | ||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•