402593 - Sunbird lacks Ctrl+Q to exit

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, enhancement)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thunderbird has Ctrl+Q to exit, so I think Sunbird should have it too.

Comment 1

[Stefan Sitter [:ssitter]]

Open for discussion: Both Firefox and Sunbird don't have Ctrl+Q. 
A similar bug for Firefox was resolved Wontfix (Bug 189290). It seems that this was fixed for Calendar long ago but now it's gone again: Bug 166173. There is also a very long discussion about Ctrl+Q in Bug 52821.

Comment 2

[Anant Narayanan [:anant]]

We can fix this when Bug 189290 has been reviewed again.

Comment 3

[Anant Narayanan [:anant]]

Attachment: patch v1: adds Ctrl-Q shortcut for quit

The patch assigns a Ctrl-Q shortcut to Sunbird's 'File' menu on Linux. (OS X and Windows already have this). If firefox gets the shortcut (per comment #24 on bug #189290), sunbird should get it too.

Comment 4

[Lars Wohlfahrt (thetux)]

Anant: "OS X and Windows already have this". 

If I'm not wrong, sunbird does not have it on Windows. 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/20080110 Calendar/0.8pre ID:2008011005

Comment 5

[Anant Narayanan [:anant]]

Looks like I was mislead by the 'x' accesskey assigned to 'Exit' on Windows (in the code, I don't have Windows so I couldn't see for sure). I hope Alt-F4 works on Windows, though; since Cmd-Q does work on the Mac. Similarly, Ctrl-Q should work on Linux as both the Gnome and KDE HIGs recommend it.

Comment 6

[Lars Wohlfahrt (thetux)]

Alt+F4 works, same for Alt+F then X.

Comment 7

[Simon Paquet [:sipaq]]

Comment on attachment 296386 [details] [diff] [review]
patch v1: adds Ctrl-Q shortcut for quit

Please note that this would break the string freeze, if this patch gets checked in before 0.8 is out.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 296386 [details] [diff] [review]
patch v1: adds Ctrl-Q shortcut for quit

r=philipp

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED