402612 - Reenable MOZ_COUNT_[CD]TOR in CToken and ~CToken

Status: RESOLVED WONTFIX

(Core :: DOM: HTML Parser, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

I really don't know why these were commented out, because even if CToken isn't refcounted this is still useful for detecting when CTokens are leaked (as currently happens with the currently-remaining nsStringBuffer leaks in bug 395845).  I suspect whoever did this was just confused about how these macros are actually supposed to be used.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I wonder if this was commented out to handle the case of purposely leaving tokens allocated and letting the destruction of their arena deallocate them. That's bogus, of course, since you always have to run destructors but it's the only explanation that I can come up with.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't think this is the way to go.  Since tokens are refcounted, I think we should log the refcounting.  That's basically what I'm doing for the patch in bug 402633.

Comment 3

[Jeff Walden [:Waldo]]

Oh, I didn't look far enough to see that -- I wasn't really expecting parser tokens were refcounted, to be honest.  Given that, yeah, this is clearly WONTFIX.