402654 - No border under title bar in View Source window

Status: VERIFIED FIXED

(Toolkit :: View Source, defect, P3)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9a9pre) Gecko/2007110518 Minefield/3.0a9pre

The View Source window has no dark border between the light-gray titlebar and the white content area.  This looks weird.

Comment 1

[Jesse Ruderman]

Josh points out that this also affects Preferences.

Comment 2

[Marcia Knous [:marcia]]

I see an issue with the border missing in the titlebar on Leopard using the latest nightly. Screenshot coming.

Comment 3

[Marcia Knous [:marcia]]

Attachment: Leopard after Bug 402125 was checked in

Comment 4

[Marcia Knous [:marcia]]

tchung says this might be intended.

(In reply to comment #2)
> I see an issue with the border missing in the titlebar on Leopard using the
> latest nightly. Screenshot coming.
> 

Comment 5

[Colin Barrett [:cbarrett]]

(In reply to comment #3)
> Created an attachment (id=287544) [details]
> Leopard after Bug 402125 was checked in

Works as intended, see bug 402125.

Comment 6

[Colin Barrett [:cbarrett]]

Rather, the main browser window is works as intended. NOT the view source window.

Comment 7

[Mike Connor [:mconnor]]

Need to make sure we're only applying this to the windows we want to apply it to.

-> Kevin

Comment 8

[Håkan Waara]

I think this is a widget bug; we shouldn't make all top-level windows get the unified toolbar style by default, unless they opt-in to get it.

All other windows not choosing to get the unified style would get a real title bar. (See also bug 405125)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> I think this is a widget bug; we shouldn't make all top-level windows get the
> unified toolbar style by default, unless they opt-in to get it.

Doesn't this window get the unified look because of http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/pinstripe/global/global.css&rev=1.16&mark=108-123#108 ?

Comment 10

[Colin Barrett [:cbarrett]]

(In reply to comment #8)
> I think this is a widget bug; we shouldn't make all top-level windows get the
> unified toolbar style by default, unless they opt-in to get it.
> 
> All other windows not choosing to get the unified style would get a real title
> bar. (See also bug 405125)

That is how it works. The theme is opting in all windows. Not a widget bug.

Comment 12

[Mike Connor [:mconnor]]

Fixed in current trunk.

Comment 13

[Bob Uliss]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0

Fixed

Comment 14

[Hasham]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008053008 Firefox/3.0

Marking as verified.