Closed Bug 402670 Opened 18 years ago Closed 18 years ago

Sometimes the update.rdf is empty, but there are updates on AMO

Categories

(addons.mozilla.org Graveyard :: Administration, defect)

Product:
addons.mozilla.org Graveyard
Component:
Administration
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: aryx, Unassigned)

Details

Attachments

(1 file)

v1, patch to use strpos in os detection rather than exact match plus tests
3.88 KB, patch
clouserw
: review+
Details | Diff | Splinter Review
Ok, tested with Firefox Trunk (but shouldn't cause the problem). IP for addons.mozilla.org is 63.245.213.31 The following update checks sometimes send an update an sometimes not: https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={7E7165E2-0767-448c-852F-5FA8714F2C37}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={31513E58-F253-47ad-86DB-D5F21E905429}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={5D558C43-550F-4b12-84AB-0D8ABDA9F975}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={3cd27e92-1a30-11da-94c6-00e08161165f}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={e2fda1a4-762b-4020-b5ad-a41df1933103}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.6pre&appOS=WINNT&appABI=x86-msvc The problem seems to also occur for these URLs: https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={3b56bcc7-54e5-44a2-9b44-66c3ef58c13e}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={78136133-1994-415a-8d30-69d505d924fc}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.6pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={b243fe83-b8a7-47de-855d-21d865243d5d}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.6pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={84850033-8F7A-462e-A311-BF1001B28FD5}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.6pre&appOS=WINNT&appABI=x86-msvc And these URLs always send an empty response: https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={4526df28-5f29-4e21-bd59-b6c549073dde}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id=compact-menu@cdn.mozdev.org&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={1FD08D8-A2CB-46c0-B36D-3F531AC53C12}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={3329801b-f8dd-4503-bdb5-6e0a076b5364}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id=ctc&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id=timestatus@webdesigns.ms11.net&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={24898804-7da3-4355-9e8d-065f3ee79ccc}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id=titletweak@webdesigns.ms11.net&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={1abc4a33-ea62-4330-966c-7bdad3455322}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={54d2d08d-f0b9-48b5-8541-6539042e90a4}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc
(In reply to comment #0) > Ok, tested with Firefox Trunk (but shouldn't cause the problem). Have you checked the compatibility ranges for all of these?
Ok, forget the last group, but https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={3cd27e92-1a30-11da-94c6-00e08161165f}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc is an example. Worked between 20:30 an 21:00 UTC and didn't work at 22:05 UTC. The same for https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={e2fda1a4-762b-4020-b5ad-a41df1933103}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.6pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={5D558C43-550F-4b12-84AB-0D8ABDA9F975}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={31513E58-F253-47ad-86DB-D5F21E905429}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={7E7165E2-0767-448c-852F-5FA8714F2C37}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc I can send you the IP by mail or in IRC.
Sending over to server-ops. I think the problem could be a slave that isn't updating. Could you guys take a look to verify that they are not behind? If they are fine, then send it back my way (addons.mozilla.org -> Administration).
Assignee: nobody → server-ops
Component: Add-ons → Server Operations
Product: addons.mozilla.org → mozilla.org
Version: 3.0 → other
Assignee: server-ops → aravind
The slaves say they are 0 seconds behind. I ran this query: SELECT addons.guid as guid, addons.id as id, addons.addontype_id as type, applications.guid as appguid, appmin.version as min, appmax.version as max, files.id as file_id, files.hash, files.filename, versions.version as version FROM versions INNER JOIN addons ON versions.addon_id = addons.id AND addons.guid = '{7E7165E2-0767-448c-852F-5FA8714F2C37}' AND addons.status = 4 AND addons.inactive=0 INNER JOIN applications_versions ON applications_versions.version_id = versions.id INNER JOIN applications ON applications_versions.application_id = applications.id AND applications.guid = '{ec8030f7-c20a-464f-9b0e-13a3a9e97384}' INNER JOIN appversions appmin ON appmin.id = applications_versions.min INNER JOIN appversions appmax ON appmax.id = applications_versions.max INNER JOIN files ON files.version_id = versions.id AND (files.platform_id = 1 OR files.platform_id = '2' ) AND files.status = 4 ORDER BY versions.id DESC LIMIT 1 which should be for https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={7E7165E2-0767-448c-852F-5FA8714F2C37}&version=0.0.1&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9pre&appOS=WINNT&appABI=x86-msvc It was an empty result on the master and both slaves.
Reassigning to addons. Let us know if we can do anything else.
Assignee: aravind → nobody
Component: Server Operations → Administration
Product: mozilla.org → addons.mozilla.org
QA Contact: add-ons → administration
Version: other → unspecified
Thanks Jeremy -- tryin to figure out what is causing this.
Status: NEW → ASSIGNED
The problem was strtolower('WINNT') not being equivalent to the expected 'win' in appOS. The script works for roughly 99% of users in this case, which the edge cases being the URLs you mentioned. The problem arises only for those extensions who are platform-specific and do not have platform_id = 1 (ALL). I added tests to verify the fuzzy match along with the positive update result for a platform-specific add-on so we should account for this case moving forward.
Attachment #287815 - Flags: review?
Attachment #287815 - Flags: review? → review?(clouserw)
Comment on attachment 287815 [details] [diff] [review] v1, patch to use strpos in os detection rather than exact match plus tests The patch looks good, but while I was in update.php I noticed line 400 was trying to match the OS in the user agent and returning based on that. These pages are cached, so I think that could be messing things up too.
Attachment #287815 - Flags: review?(clouserw) → review+
I stripped out the UA checking based on comment #9. That makes sense and would explain the flip-flopping. This is checked in and we should be able to update this on Tuesday.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Ok, the flip-flopping seems to be fixed, but demanding the following URLs still shows differences in the results between Windows and Linux. So the UA checking still is probably somewhere active. https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={3cd27e92-1a30-11da-94c6-00e08161165f}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={5D558C43-550F-4b12-84AB-0D8ABDA9F975}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={31513E58-F253-47ad-86DB-D5F21E905429}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.6&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={7E7165E2-0767-448c-852F-5FA8714F2C37}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={77b819fa-95ad-4f2c-ac7c-486b356188a9}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={3b56bcc7-54e5-44a2-9b44-66c3ef58c13e}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.9&appOS=WINNT&appABI=x86-msvc https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={e2fda1a4-762b-4020-b5ad-a41df1933103}&version=0.0&maxAppVersion=2.0.0.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=2.0.0.9&appOS=WINNT&appABI=x86-msvc
The Tuesday update was pushed back to tonight -- so can we reevaluate after the update during tonight's window? Thanks for taking a look at this, by the way -- appreciate it.
Sorry for the impatience. It works now. Thank you for the fix.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: