402724 - Sync build configs for Firefox trunk

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

The idea is to remove all the trivial differences between configs for en-US nightlies, l10n nightlies, and en-US release - the end goal being to make it easier to make l10n release configs, and to be able to diff between sets to see the real differences.

Patches coming up.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: en-US nightly changes

* update machine info lines
* remove MOZILLA_OFFICIAL declarations that we only have on linux and which Tinderbox makes if we have $ReleaseBuild=1 (http://mxr.mozilla.org/seamonkey/source/tools/tinderbox/build-seamonkey-util.pl#456)
* remove old comments, including MoFoRoot (no talkback on trunk)
* put crashreporter/breakpad settings in consistent place
* push_raw_xpis=0 since we don't use the stub installer since forever
* remove MOZ_INSTALLER_USE_7ZIP and MOZ_PACKAGE_NSIS, as they are no longer used on trunk (eg http://mxr.mozilla.org/seamonkey/search?string=MOZ_INSTALLER_USE_7ZIP&find=&findi=&filter=&tree=seamonkey)
* use_blat is always true (seems broken, http://mxr.mozilla.org/seamonkey/source/tools/tinderbox/build-seamonkey-util.pl#653)

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: en-US Release changes

* Much of the commments for the previous patch apply
* re-order mozconfig/tinder-config.pl to be consistent with en-US nightly

I'm pretty sure there are no functionality changes here.

Comment 3

[(not currently active) Ted Mielczarek]

(In reply to comment #1)
> * update machine info lines
> * remove MOZILLA_OFFICIAL declarations that we only have on linux and which
> Tinderbox makes if we have $ReleaseBuild=1

I'm personally not a big fan of the tinderbox magic.  I think things like this should be explicitly set in the configs, so we aren't bitten if we try to move things over to buildbot.  Also it makes things less confusing for people trying to replicate our official builds.

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 287545 [details] [diff] [review]
en-US nightly changes

Yay cleanup!

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 287546 [details] [diff] [review]
en-US Release changes

Yay cleanup!

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: l10n nightly cleanup

And finally the l10n changes. This one is messier, but basically:

* comments for previous patches
* there are a bunch of useless looking changes, like turning on tests that never get run because $RunMozillaTests=0, or changing comments (SkipMozilla), but it's all in aid syncing with en-US nightlies
* all the l10n config consolidated into one block

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #3)
> I'm personally not a big fan of the tinderbox magic.  I think things like this
> should be explicitly set in the configs, so we aren't bitten if we try to move
> things over to buildbot.  Also it makes things less confusing for people trying
> to replicate our official builds.

It's a good point, but I recall using the mozconfig to set MOZILLA_OFFICIAL was broken. Admittedly this was some time and ago it may be fixed by now. Also, it would be good to do an audit on where the *_OFFICIAL variables are used, as it may not be desirable for non-mozilla builds to have them enabled.

Comment 8

[(not currently active) Ted Mielczarek]

Yeah, I agree that having non-working options in the config files is worse.  Also, I'm more concerned with us being able to track these things in the future, especially since we'd like to move away from Tinderbox.  Relying on tinderbox magic to turn on necessary settings is just a maintenance nightmare.

Comment 9

[Chris Cooper [:coop] (he/him)]

Comment on attachment 287552 [details] [diff] [review]
l10n nightly cleanup

One thing I might suggest for the future (which I've started doing myself now) is completely removing the commented sections that don't change from the defaults.    Makes for much shorter, more easily parseable tinder-config.pls. Dealing with some of the XR configs over the past week where this is already the case has been nice.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

All landed. --> FIXED