Closed Bug 402763 Opened 17 years ago Closed 17 years ago

Cycle collect on memory-pressure

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta1

People

(Reporter: sicking, Assigned: sicking)

Details

Attachments

(1 file)

Patch to fix
3.41 KB, patch
pavlov
: review+
pavlov
: superreview+
mtschrep
: approvalM9+
Details | Diff | Splinter Review
Attached patch Patch to fix — — Splinter Review 
We should cycle collect on the memory-pressure notification. I also noticed that the API to force a CC should do so through JSContext in order to let it know that a cc has happened recently.
Attachment #287579 - Flags: superreview?(pavlov)
Attachment #287579 - Flags: review?(pavlov)
Attachment #287579 - Attachment is patch: true
Attachment #287579 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 287579 [details] [diff] [review]
Patch to fix

looks good.
Attachment #287579 - Flags: superreview?(pavlov)
Attachment #287579 - Flags: superreview+
Attachment #287579 - Flags: review?(pavlov)
Attachment #287579 - Flags: review+
Flags: blocking1.9+
Target Milestone: --- → mozilla1.9 M9
Comment on attachment 287579 [details] [diff] [review]
Patch to fix

a+ schrep so we can get access to explict cc through extensions in b1
Attachment #287579 - Flags: approvalM9? → approvalM9+
sicking landed this on the trunk.

2007-11-06 13:48	mozilla/dom/src/base/nsJSEnvironment.cpp 	1.364
2007-11-06 13:47	mozilla/dom/src/base/nsDOMWindowUtils.cpp 	1.19
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Is there a way to test this patch (to be able to verify it)?
Adding a mochitest or unittest should be possible.
The test could notify "memory-pressure" and that should cause a new notification
"cycle-collector-begin".
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: