402775 - NSS_USE_SYSTEM_SQLITE should be complete

Status: RESOLVED INACTIVE

(NSS :: Libraries, defect, P5)

Description

[Kai Engert [:KaiE:]]

NSS should support building with either the locally included sqlite, or with a globally installed system sqlite.

It appears support for both combinations is intended, because mozilla/security/nss/lib/Makefile tests for variable NSS_USE_SYSTEM_SQLITE. If set, NSS will not build in its local sqlite directory.

When using a system sqlite, NSS should not use its local include files.
I propose to change softoken/legacydb/manifest.mn and softoken/manifest.mn
which currently do
  INCLUDES += -I$(DIST)/include/sqlite3

to wrap that into a
  #ifndef NSS_USE_SYSTEM_SQLITE
as well.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Hmm, both makefiles define

ifdef MOZILLA_CLIENT
INCLUDES += -I$(DIST)/include/sqlite3
endif

Are you talking about using system sqlite when built within mozilla or NSS as standalone build?

Comment 2

[Robert Relyea]

NSS standalone on a platform with a system version of sqlite already packages. (Most Linux systems, for instance).

bob

Comment 3

[Robert Relyea]

OK I didn't understand the combination of Kaie's request and Wolfgang's comments.

Kai, are we taking about building in the mozilla environment with the system version of sqlite?

I'm OK with the ifndefs, I just want to make sure we understand the case we are talking about. (MOZILLA_CLIENT shouldn't be on in the case of NSS standalone builds, in that case the sqlite3 include files will be in the normal NSS include directory wjen building without the system NSS).

bob

Comment 4

[Kai Engert [:KaiE:]]

(In reply to comment #3)
> 
> Kai, are we taking about building in the mozilla environment with the system
> version of sqlite?

I don't remember exactly how I learned about this.

If I read my own comments correctly, I think the important point is:

NSS always uses its own header files, but sometimes it must use headers from somewhere else.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.