Closed Bug 402853 Opened 13 years ago Closed 12 years ago

linker warnings for libxul

Categories

(Core :: Graphics, defect)

x86
Windows Server 2003
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: nthomas, Assigned: benjamin)

References

Details

Attachments

(2 files)

Saw these in the 3.0b1 build, and bug 388663 comment #14 indicates when it started.
I remember asking in IRC about them back in the day and was told that they're not a concern, FWIW. They are certainly an irritant, though.
Summary: compiler warnings linking libxul → linker warnings for libxul
Attached patch Guess, rev. 1Splinter Review
This is a well-educated but completely untried guess. Maybe I should ask the tryserver.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #287708 - Flags: review?(ted.mielczarek)
FWIW, this was green on the tryserver and there were no warnings.
Attachment #287708 - Flags: review?(ted.mielczarek) → review+
Attachment #287708 - Flags: approval1.9?
Comment on attachment 287708 [details] [diff] [review]
Guess, rev. 1

a=release drivers
Attachment #287708 - Flags: approval1.9? → approval1.9+
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 403271
Backed out in an attempt to fix orange.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This caused red later in the day when smaug and I checked in changes to layout.  I guess it needed at least an objdir clobber.

This is also one of the two bugs (along with bug 402198) still suspected of causing the prolonged orange on the Windows unit test boxes over the weekend (bug 403271 comment 7).  That orange could only be fixed by doing a srcdir clobber, so please reland this at a time when robcee is around (coordinate using #developers).
relanded.

Checking in config/config.mk;
/cvsroot/mozilla/config/config.mk,v  <--  config.mk
new revision: 3.380; previous revision: 3.379
done
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
No longer depends on: 403724
Depends on: 403724
You need to log in before you can comment on or make changes to this bug.