402912 - "###!!! ASSERTION: bad pref, min, max size" with XUL equalsize, flex

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: bad pref, min, max size: '(boxSizes->min <= boxSizes->pref && boxSizes->pref <= boxSizes->max)', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/nsSprocketLayout.cpp, line 1184

Comment 1

[Jesse Ruderman]

Why "DUPEME"?  I searched Bugzilla for the assertion before filing the bug, and the only mentions were in the fixed bug 382899 and invalid bug 83368.

Comment 2

[[e-mail]]

Because I didn't remember fixing bug 382899. D'oh!

Comment 3

[[e-mail]]

OK, so the problem appears to be here:
            if (childActualWidth > childLayoutWidth) {
               aChildComputedSize->size = childActualWidth;
               aChildBoxSize->min = childActualWidth;
               if (aChildBoxSize->pref < childActualWidth)
                  aChildBoxSize->pref = childActualWidth;
Note that this can increase the minimum width, and it will of course increase the preferred width to match, but it fails to increase the maximum width.

Comment 4

[[e-mail]]

Attachment: Proposed patch

This fixes the assertion and seems to be the correct approach.

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Jesse Ruderman]

Crashtest checked in.