402923 - Get rid of CGImageCreate 0x0 size warning

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix

This spams the error console in some circumstances; easy fix.  CGImageCreate was returning NULL before, so this does everything the same, just without a bunch of extra work and no error print.

Comment 1

[Mike Schroepfer]

Note - I can reproduce this trivially:

1) Fire up minefield on MacOS
2) Tools->Add-ons
3) Move the mouse over the close box in the upper right
4) Note the error on the console

Not sure if this is serious - so wanted to give STR to see if there is something bad going on there....

Comment 2

[Mike Schroepfer]

Before we check the walpaper in can we confirm that this doesn't indicate some kind of error?

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 287741 [details] [diff] [review]
fix

Vlad, if schrep's concerns are valid, please hold off on landing

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 287741 [details] [diff] [review]
fix

Killing this patch; this'll be fixed in a different way when I upgrade cairo.

There's no error -- what's happening is that everything is being clipped out, so at some point we start to try to draw something that requires alpha blending and we try to create a temporary 0x0 surface.  The situation isn't ideal for now, but it doesn't trigger any other problem, other than the warning.

Comment 5

[Reed Loden [:reed]]

Comment on attachment 287741 [details] [diff] [review]
fix

Clearing approval1.9+.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This got fixed inside cairo.