Closed Bug 403027 Opened 14 years ago Closed 14 years ago
pxp01 & 03 failing to restart
talos blades are failing to restart due to lingering session materials in the profile. Bhearsum noticed that they were presenting a session restore dialog on next run. We should create a buildstep to remove the profile directory in C:\documents and settings\administrator\local settings\temp to prevent this in the future.
I'm seeing: Deleted file - C:\slave\trunk19\firefox-3.0b2pre.en-US.win32.zip Could Not Find C:\mozilla\testing\performance\talos\*.yml Could Not Find C:\slave\trunk19\rmdir program finished with exit code 0 in the Remove download build step for these machines. Later extracts might have included left-overs in the firefox directory.
That directory shouldn't be hanging around anyway, looks like there is a bug in the talos code that is allowing it to hang around. Buildbot should still probably try and remove it (just in case talos dies in a catastrophic manner), but I should also come up with a patch to fix the talos bug.
The temporary profile directory was being created with an additional subdirectory called 'profile' that contained the actual copied base_profile - by removing the extra layer of directory it is correctly removed at the end of the test.
Attachment #287857 - Flags: review?(rcampbell)
Comment on attachment 287857 [details] [diff] [review] correctly create the temp profile directory discussing with stuart, I think you still need to use mkdtemp instead of mktemp (which is deprecated and creates a file instead of a directory).
Attachment #287857 - Flags: review?(rcampbell) → review-
Okay, so people didn't really like that first try. Now I keep track of both the location of the profile directory and the temporary directory that it is stored in. At the end of the test the temporary directory is removed.
a complementary patch to the talos patch! This separates the different cleaning buildsteps and adds a step to remove the temp directories before running the perf tests.
Attachment #287872 - Flags: review?(anodelman)
Attachment #287871 - Flags: review?(rcampbell) → review+
Comment on attachment 287872 [details] [diff] [review] 403027.patch In future, we'll need this for firefox branch as well.
Attachment #287872 - Flags: review?(anodelman) → review+
Checking in ffsetup.py; /cvsroot/mozilla/testing/performance/talos/ffsetup.py,v <-- ffsetup.py new revision: 1.4; previous revision: 1.3 done Checking in ttest.py; /cvsroot/mozilla/testing/performance/talos/ttest.py,v <-- ttest.py new revision: 1.5; previous revision: 1.4 done
cvs commit: Examining . cvs commit: Examining configs cvs commit: warning: directory CVS specified in argument cvs commit: but CVS uses CVS for its own purposes; skipping CVS directory Checking in master.cfg; /cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/master.cfg,v <-- master.cfg new revision: 1.18; previous revision: 1.17 done
left out the "do" portion of the for command causing failures. Also turned off failures and warnings for this step for clean-burning smoothness.
Attachment #287998 - Flags: review?(bhearsum) → review+
cvs commit: Examining . cvs commit: Examining configs cvs commit: warning: directory CVS specified in argument cvs commit: but CVS uses CVS for its own purposes; skipping CVS directory Checking in master.cfg; /cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/master.cfg,v <-- master.cfg new revision: 1.19; previous revision: 1.18 done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.
Component: Testing → Release Engineering
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.