403033 - [tinderbox-client] Refactor get_buildid to amalgamate special cases

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, enhancement, P3)

Description

[Chris Cooper [:coop] (he/him)]

This came out of IRC discussion around the patch for bug 388654. 

We currently do a lot of special case hand-waving about finding the build ID. This is one of the few instances in tinderbox where we *do* check return values, but we get it wrong often, especially for new builds.

Here are the various cases I can think of that differ in terms of how we lookup the build ID:

* 1.9 (not dependent on breakpad) -> platform.ini
* 1.9 apps based on XR -> platform.ini
* 1.8 w/ Talkback -> master.ini
* 1.8 w/o Talkback, but with $ReleaseBuild set -> fabricate a build ID (note; this is a change from the current state. I assume here that if a person has chosen a $ReleaseBuild but not enabled Talkback, they are doing so consciously.)

This gives us very specific criteria for either finding or fabricating a build ID, and if codified will make build ID-related failures less frequent, and more meaningful when they do occur.