403080 - web services review

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Mic Berman]

shalom,
please create a patch and rationale for changes to search plug-ins between Firefox 2 and 3
thanks

Comment 1

[Axel Hecht [:Pike]]

Gavin, could you enlighten me on the difference between OpenSearchDescription and SearchPlugin as toplevel element names between OpenSearch and MozSearch?

Mic, do we have any obligation about the source=moz parameter for nana.co.il?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The ugly details are at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/search/nsSearchService.js&rev=1.103&mark=1323-1341#1315 . It is MozSearch vs. OpenSearch as you mention ("SearchPlugin" being the root localName for MozSearch). We currently deal with them the same way, so the same child elements are handled identically. You just need to pass one of the checks in that code.

http://developer.mozilla.org/en/docs/Creating_MozSearch_plugins has a note and some docs that are relevant.

Comment 3

[Mic Berman]

Axel,
sorry - what do you mean obligation for source=moz parameter?

Comment 4

[Axel Hecht [:Pike]]

In https://bugzilla.mozilla.org/attachment.cgi?id=287772&action=diff#he/browser/searchplugins/nana.xml_sec1, there is a removal of 

<Param name="source" value="moz"/>

which means that we'll not send that parameter to the search provider anymore.

Comment 5

[Mic Berman]

thanks, i remember that now from one other locale ;)

Comment 6

[Tomer Cohen :tomer]

The current /l10n/he/browser/searchplugins synced to old revision of Firefox 2, before we've converted these files to mozsearch. I've resynced the directory, so now everything seem to be ok. 

Comment 7

[Mic Berman]

axel re: comment #1
i need to double check in my records to see if Nana.co.il required this
Tomer re: comment #6 does this mean the search plug in files are now reverted back to the way they were in Fx2 including the source=moz parameter for nana.co.il?
thanks
michal

Comment 8

[Axel Hecht [:Pike]]

Looking at the state of the cvs trunk now, there is no diff for search (other than a comment) or bookmarks right now.

I'm marking this FIXED, as the essentials of the initial bug are. We might file a new bug to get the web services localization complete for fx3, including the new protocal handler stuff (with background info), that should keep track of search change requests, too.