Closed Bug 403153 Opened 12 years ago Closed 12 years ago

Self describing text in the bookmarks organizer search box should be "Search Bookmarks"


(Firefox :: Bookmarks & History, defect, P3)




Firefox 3 beta4


(Reporter: faaborg, Assigned: ehsan)



(Keywords: late-l10n, polish)


(1 file, 3 obsolete files)

Self describing text in the bookmarks organizer search box should be "Search Bookmarks" (currently "Search in Bookmarks.")

See bug# 393514 for a mockup.
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P3
Target Milestone: --- → Firefox 3 M11
Attached patch Patch (v1) (obsolete) — Splinter Review
Trivial patch to change the string
Assignee: nobody → ehsan.akhgari
Attachment #300349 - Flags: review?(mano)
Nominating late-l10n because this is blocking and it's purely a string change, and it's not in the tree yet.
Keywords: late-l10n
OS: Windows Vista → All
Hardware: PC → All
Comment on attachment 300349 [details] [diff] [review]
Patch (v1)

Entities ought to be renamed when changed.
Attachment #300349 - Flags: review?(mano) → review-
Attached patch Patch (v2) (obsolete) — Splinter Review
I renamed the entity name this time as well.
Attachment #300349 - Attachment is obsolete: true
Attachment #300399 - Flags: review?(mano)
Comment on attachment 300399 [details] [diff] [review]
Patch (v2)

I would just call it "searchBookmarks"

r=mano either way.
Attachment #300399 - Flags: review?(mano) → review+
Attached patch Patch (v2.1) (obsolete) — Splinter Review
Nit in comment 5 addressed.

Carrying over mano's r+.  This won't need approval1.9, because it's been deemed blocking, but since this is a l10n change, and is pretty low risk, I guess it would be good to land this for beta 3, so I'm asking approval1.9b3.
Attachment #300399 - Attachment is obsolete: true
Attachment #300457 - Flags: review+
Attachment #300457 - Flags: approval1.9b3?
Comment on attachment 300457 [details] [diff] [review]
Patch (v2.1)

This will have to miss beta 3, we'll get it in the next beta.
Attachment #300457 - Flags: approval1.9b3? → approval1.9b3-
What's the point here?

"Search Bookmarks" vs "Search in Bookmarks" doesn't look vital to me.
Not vital, just a string change for polish
Given that this was deemed blocking-firefox3+ back in November, it might be a good idea to re-evaluate that then?
This is the unbitrotted patch of attachment 300457 [details] [diff] [review] for check-in.
Attachment #300457 - Attachment is obsolete: true
Requesting check-in for attachment 302610 [details] [diff] [review].  a=blocking-firefox3+
Keywords: checkin-needed
This is late-l10n, so it needs explicit approval.
Keywords: checkin-needed
Attachment #302610 - Flags: approval1.9?
Attachment #302610 - Flags: approval1.9? → approval1.9+
CCing firefoxl10n to increase the chance of localizers getting notified sooner.
Target Milestone: Firefox 3 beta3 → Firefox 3 beta4
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.127; previous revision: 1.126
Checking in browser/locales/en-US/chrome/browser/places/;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/,v  <--
new revision: 1.37; previous revision: 1.36
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #302610 - Attachment description: Patch (for checkin) → Patch (checked in)
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022204 Minefield/3.0b4pre. 
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.