403153 - Self describing text in the bookmarks organizer search box should be "Search Bookmarks"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Self describing text in the bookmarks organizer search box should be "Search Bookmarks" (currently "Search in Bookmarks.")

See bug# 393514 for a mockup.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Trivial patch to change the string

Comment 2

[(no longer active)]

Nominating late-l10n because this is blocking and it's purely a string change, and it's not in the tree yet.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 300349 [details] [diff] [review]
Patch (v1)

Entities ought to be renamed when changed.

Comment 4

[(no longer active)]

Attachment: Patch (v2)

I renamed the entity name this time as well.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 300399 [details] [diff] [review]
Patch (v2)

I would just call it "searchBookmarks"

r=mano either way.

Comment 6

[(no longer active)]

Attachment: Patch (v2.1)

Nit in comment 5 addressed.

Carrying over mano's r+.  This won't need approval1.9, because it's been deemed blocking, but since this is a l10n change, and is pretty low risk, I guess it would be good to land this for beta 3, so I'm asking approval1.9b3.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300457 [details] [diff] [review]
Patch (v2.1)

This will have to miss beta 3, we'll get it in the next beta.

Comment 8

[Axel Hecht [:Pike]]

What's the point here?

"Search Bookmarks" vs "Search in Bookmarks" doesn't look vital to me.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Not vital, just a string change for polish

Comment 10

[Axel Hecht [:Pike]]

Given that this was deemed blocking-firefox3+ back in November, it might be a good idea to re-evaluate that then?

Comment 11

[(no longer active)]

Attachment: Patch (checked in)

This is the unbitrotted patch of attachment 300457 [details] [diff] [review] for check-in.

Comment 12

[(no longer active)]

Requesting check-in for attachment 302610 [details] [diff] [review].  a=blocking-firefox3+

Comment 13

[Reed Loden [:reed]]

This is late-l10n, so it needs explicit approval.

Comment 14

[(no longer active)]

CCing firefoxl10n to increase the chance of localizers getting notified sooner.

Comment 15

[Reed Loden [:reed]]

Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.127; previous revision: 1.126
done
Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v  <--  places.properties
new revision: 1.37; previous revision: 1.36
done

Comment 16

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022204 Minefield/3.0b4pre. 

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv