403175 - [FIX]"ASSERTION: Wrong parent style context" with <table align=right>

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase (keeps trying to trigger the assertion)

The testcase triggers the following assertion on about 70% of its iterations.

frame: Placeholder(table)(0) (0x3f988aa8) style: 0x3f988284 :-moz-non-element {}
###!!! ASSERTION: Wrong parent style context: 'Error', file /Users/jruderman/trunk/mozilla/layout/base/nsFrameManager.cpp, line 819
Wrong parent style context:  style: 0x3f98b1c0 {}
should be using:  style: 0x25d1ea0 {}

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

We were using the parent of the outer table's style context, which is the inner table's style context, as the style context parent for the placeholder.  We want to be using the parent of the inner table's style context (in this case, the body's style context).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: The right patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 4

[[e-mail]]

Comment on attachment 288104 [details] [diff] [review]
The right patch

>+  NS_PRECONDITION(aStyleDisplay == aNewFrame->GetStyleDisplay(),
>+                  "Wrong display struct?");
Splitters don't like this, but then again // XXXbz this is pretty messed up

Comment 5

[[e-mail]]

Sorry for the spam, I overlooked bug 404218...

Comment 6

[Jesse Ruderman]

Crashtest checked in.