Closed Bug 403175 Opened 12 years ago Closed 12 years ago

[FIX]"ASSERTION: Wrong parent style context" with <table align=right>

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, testcase)

Attachments

(2 files, 1 obsolete file)

The testcase triggers the following assertion on about 70% of its iterations.

frame: Placeholder(table)(0) (0x3f988aa8) style: 0x3f988284 :-moz-non-element {}
###!!! ASSERTION: Wrong parent style context: 'Error', file /Users/jruderman/trunk/mozilla/layout/base/nsFrameManager.cpp, line 819
Wrong parent style context:  style: 0x3f98b1c0 {}
should be using:  style: 0x25d1ea0 {}
Attached patch Fix (obsolete) — Splinter Review
We were using the parent of the outer table's style context, which is the inner table's style context, as the style context parent for the placeholder.  We want to be using the parent of the inner table's style context (in this case, the body's style context).
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #288103 - Flags: superreview?(roc)
Attachment #288103 - Flags: review?(roc)
OS: Mac OS X → All
Hardware: PC → All
Summary: "ASSERTION: Wrong parent style context" with <table align=right> → [FIX]"ASSERTION: Wrong parent style context" with <table align=right>
Attached patch The right patchSplinter Review
Attachment #287969 - Attachment is obsolete: true
Attachment #288104 - Flags: superreview?(roc)
Attachment #288104 - Flags: review?(roc)
Attachment #288103 - Attachment is obsolete: true
Attachment #288103 - Flags: superreview?(roc)
Attachment #288103 - Flags: review?(roc)
Attachment #288104 - Flags: superreview?(roc)
Attachment #288104 - Flags: superreview+
Attachment #288104 - Flags: review?(roc)
Attachment #288104 - Flags: review+
Attachment #288104 - Flags: approval1.9?
Attachment #288104 - Flags: approval1.9? → approval1.9+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Depends on: 404218
Comment on attachment 288104 [details] [diff] [review]
The right patch

>+  NS_PRECONDITION(aStyleDisplay == aNewFrame->GetStyleDisplay(),
>+                  "Wrong display struct?");
Splitters don't like this, but then again // XXXbz this is pretty messed up
Sorry for the spam, I overlooked bug 404218...
Attachment #287969 - Attachment is obsolete: false
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.