403180 - test_378216.js is asserting, but after printing PASS (so the test passes)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jeff Walden [:Waldo]]

Our success condition for a test passing is that "PASS" is in its output, but if a test passes and then asserts, it should fail.  (There's a bug on file, Core:Testing somewhere.)  This test looks like it's being bitten by this problem; I haven't investigated to see exactly what's wrong with it.

Comment 1

[Jesse Ruderman]

Bug 368573, "Need a way to run tests (mochikit/reftest) that display as failed when assertion failures are encountered"?

Can you paste the assertion message in a comment here?

Comment 2

[Jeff Walden [:Waldo]]

This is one of the xpcshell tests, not a reftest/Mochitest; it's bug 353010.

The assertion is the generic "XPConnect called on scope without Components property", so some callback dance isn't being done correctly.

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Shut down the server before ending testing

A look at the stack of the assertion showed it happened in IO thread shutdown; a quick glance at the test showed it starts an HTTP server but never stops it, which causes the assertion.

I added a note to the HTTP server docs page on MDC mentioning that shutting down the server is mandatory, which hopefully might prevent this from happening as much in the future.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 289000 [details] [diff] [review]
Shut down the server before ending testing

Oops, thanks for catching that. r=me

Comment 5

[Jeff Walden [:Waldo]]

Checked in (and I suppose in-testsuite+ since the testcase is fixed now).