403297 - Zooming triggers "WARNING: Unable to test style tree integrity -- no content node"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Ctrl++ or Ctrl+- on any page triggers:

WARNING: Unable to test style tree integrity -- no content node: file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 10110

This even happens on the empty page
data:text/html,

Comment 1

[Boris Zbarsky [:bzbarsky]]

We're doing a style change on the viewport.  That's rare, but can happen....

Comment 2

[Jesse Ruderman]

It's not rare any more... can we change the assertion so it doesn't fire in this case?

Comment 3

[Boris Zbarsky [:bzbarsky]]

It's not an assertion... it's a warning.  And it _is_ rare compared to style changes in general.  ;)

We could probably skip the warning if the frame is a viewport... or even altogether. David, sound OK?

Comment 4

[Daniel Holbert [:dholbert]]

We hit this at pageload time, for files with <meta charset="utf-8">, since the charset-change happens asynchronously and triggers a rebuild of all style data starting with the viewport frame.

I agree that we should skip the warning if the frame is a viewport. (I was actually just about to file a bug on making that change, and then I ran across this one from bugzilla's new-bug-form dupe-finder.)

Comment 5

[Daniel Holbert [:dholbert]]

Minimal testcase that demonstrates the beginning of comment 4:
  data:text/html,<meta charset="utf-8">

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This patch skips the warning if we have a frame and it's a viewport frame.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 763872 [details] [diff] [review]
fix v1

r=me

Comment 8

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e93bc25a700

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1e93bc25a700