403326 - when attaching a patch, if review requestee matches multiple people no error is produced

Status: RESOLVED DUPLICATE of bug 372539

(Bugzilla :: Attachments & Requests, defect)

Description

[Bill Gianopoulos [:WG9s]]

If i click on the attachment details to request a review, and i put in requestee that matches multiple entries, i get a subsequent page to select the person I really wanted.  The same should happen if I request a review at the same time I attach a patch, but it does not.  Anything that is not entered as an exact match seems to end up with me as the review requestee with no error message.

This is happening on bugzilla.mozilla.org in case it is implementation specific.

Comment 1

[Bill Gianopoulos [:WG9s]]

(In reply to comment #0)
> same time I attach a patch, but it does not.  Anything that is not entered as
> an exact match seems to end up with me as the review requestee with no error
> message.

It does not ends up with the requestor as requestee just ends up as a review request with no requestee.

Sorry for my confusion.

Comment 2

[Frédéric Buclin]

See also bug 5179 comment 40. The current behavior is expected. If we display an intermediate page to choose the reviewer, then your web browser will be unable to cache the uploaded attachment. The best alternative was to commit the attachment first and then let you choose the reviewer again. Also, note that a message is displayed at the top of the page informing you that several names were matching the string you entered. So no error is thrown, but a message is displayed.

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> See also bug 5179 comment 40. The current behavior is expected. If we display
> an intermediate page to choose the reviewer, then your web browser will be
> unable to cache the uploaded attachment. The best alternative was to commit the
> attachment first and then let you choose the reviewer again. Also, note that a
> message is displayed at the top of the page informing you that several names
> were matching the string you entered. So no error is thrown, but a message is
> displayed.
> 
OK. Thanks the reason I was trying to avoid that is that if you do it that way it sends 2 e-mails.  Trying to avoid bugspam.

Comment 4

[Frédéric Buclin]

I will mark this bug as a dupe of bug 372539 as both are about the same problem: the lack of the "confirmation" page when entering a reviewer name.