Closed
Bug 403462
Opened 17 years ago
Closed 17 years ago
clarify localization note in blockedSite.properties
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: johnath)
References
()
Details
Attachments
(1 file)
2.00 KB,
patch
|
Pike
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
The localization note in blockedSite.properties for phishing.learnMoreLink seems to be a tad misleading, see bug 403246. It'd be nice if we could clarify that it's only affecting the markup of the link, not the anchor text. Maybe "please leave the HTML markup for ... as is." instead of the "... text". Abdulkadir, would that have helped?
Comment 1•17 years ago
|
||
Yes, or "please leave the HTML tag for ... as is." would have definitly helped.
Assignee | ||
Updated•17 years ago
|
Attachment #288309 -
Flags: review? → review?(l10n)
Reporter | ||
Comment 3•17 years ago
|
||
Comment on attachment 288309 [details] [diff] [review] Fix localization note yes, thanks. r=me
Attachment #288309 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 288309 [details] [diff] [review] Fix localization note Is this something I can land? It makes localizers' life easier, and no code is touched, just a properties file?
Attachment #288309 -
Flags: approval1.9?
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → johnath
Comment 5•17 years ago
|
||
It's a comment change... just land it once the tree reopens.
Updated•17 years ago
|
Attachment #288309 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 6•17 years ago
|
||
Checking in browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties,v <-- blockedSite.properties new revision: 1.3; previous revision: 1.2
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•