clarify localization note in blockedSite.properties

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: Pike, Assigned: johnath)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
The localization note in blockedSite.properties for phishing.learnMoreLink seems to be a tad misleading, see bug 403246.

It'd be nice if we could clarify that it's only affecting the markup of the link, not the anchor text.

Maybe "please leave the HTML markup for ... as is." instead of the "... text".

Abdulkadir, would that have helped?

Comment 1

10 years ago
Yes, or "please leave the HTML tag for ... as is." would have definitly helped.
(Assignee)

Comment 2

10 years ago
Created attachment 288309 [details] [diff] [review]
Fix localization note

Doh.  Is this text better?
Attachment #288309 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #288309 - Flags: review? → review?(l10n)
(Reporter)

Comment 3

10 years ago
Comment on attachment 288309 [details] [diff] [review]
Fix localization note

yes, thanks. r=me
Attachment #288309 - Flags: review?(l10n) → review+
(Assignee)

Comment 4

10 years ago
Comment on attachment 288309 [details] [diff] [review]
Fix localization note

Is this something I can land? It makes localizers' life easier, and no code is touched, just a properties file?
Attachment #288309 - Flags: approval1.9?
(Assignee)

Updated

10 years ago
Assignee: nobody → johnath
It's a comment change... just land it once the tree reopens.

Updated

10 years ago
Attachment #288309 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 6

10 years ago
Checking in browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties,v  <--  blockedSite.properties
new revision: 1.3; previous revision: 1.2
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.