403574 - "ASSERTION: Infinite loop! Calling EnsureScriptEnvironment() from within EnsureScriptEnvironment()!" with XBL, <frame>

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

Attachment: testcase (quit to see the assertion)

Steps to reproduce:
1. Load the testcase.
2. Quit Firefox (or wait for a GC?)

Result:

###!!! ASSERTION: Infinite loop! Calling EnsureScriptEnvironment() from within EnsureScriptEnvironment()!: '!mInEnsureScriptEnv', file /Users/jruderman/trunk/mozilla/docshell/base/nsDocShell.cpp, line 8679

(no hang or crash, though)

This assertion was added yesterday, in bug 392532.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I can't seem to reproduce this.... (with a build that does contain that patch).

Comment 2

[Jesse Ruderman]

Attachment: stack to the assertion

Comment 3

[Boris Zbarsky [:bzbarsky]]

Looks like the problem are the early returns between setting mInEnsureScriptEnv to true and setting it to false.  Presumably we take one of those at some point...  Should use a little debug object to reset  mInEnsureScriptEnv, I think.

Comment 4

[Johnny Stenback (:jst)]

Attachment: Fix.

Comment 5

[Ludek Cigler]

I'm experiencing a vaguely similar problem when porting AllPeers to Firefox 3 -- if I open  AllPeers sidebar, then close it and open again, I get an infinite loop, with this output repeatedly printed on the console:

++DOMWINDOW == 39 (0x391d450) [serial = 43] [Outer = 0x2d53c00]
JavaScript strict warning: chrome://allpeers/content/workbench/apCommon.js, line 2271: assignment to undeclared variable apUrlClass
++WEBSHELL 0x3973400 == 19
++DOMWINDOW == 40 (0x3974050) [serial = 44] [Outer = (nil)]
++WEBSHELL 0x3975400 == 20
++DOMWINDOW == 41 (0x3976050) [serial = 45] [Outer = (nil)]
++DOMWINDOW == 42 (0x39b9050) [serial = 46] [Outer = 0x3974000]
++DOMWINDOW == 43 (0x3b75c50) [serial = 47] [Outer = 0x3976000]
WARNING: empty langgroup: file /home/luigi/dev/mozilla/gfx/thebes/src/gfxFont.cpp, line 898
WARNING: NS_ENSURE_SUCCESS(EnsureContentViewer(), ((nsresult) 0x80004005L)) failed with result 0x80004005: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 3384
###!!! ASSERTION: Shouldn't be observing anymore!: '!mObservedDocument', file /home/luigi/dev/mozilla/content/xul/templates/src/nsXULTemplateBuilder.cpp, line 240
WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), 0) failed with result 0x80040111: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 4285
WARNING: NS_ENSURE_TRUE(scriptGO) failed: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 8901
WARNING: NS_ENSURE_TRUE(mWebBrowserFind) failed: file /home/luigi/dev/mozilla/toolkit/components/typeaheadfind/src/nsTypeAheadFind.cpp, line 205
WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), 0) failed with result 0x80040111: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 4285
WARNING: NS_ENSURE_TRUE(scriptGO) failed: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 8901
WARNING: NS_ENSURE_TRUE(mWebBrowserFind) failed: file /home/luigi/dev/mozilla/toolkit/components/typeaheadfind/src/nsTypeAheadFind.cpp, line 205
WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), 0) failed with result 0x80040111: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 4285
WARNING: NS_ENSURE_TRUE(scriptGO) failed: file /home/luigi/dev/mozilla/docshell/base/nsDocShell.cpp, line 8901
WARNING: NS_ENSURE_TRUE(mWebBrowserFind) failed: file /home/luigi/dev/mozilla/toolkit/components/typeaheadfind/src/nsTypeAheadFind.cpp, line 205

I tried applying the above patch, but it didn't help. Is this issue related to this bug at all?

Comment 6

[Boris Zbarsky [:bzbarsky]]

If you're not seeing that assertion, you're not seeing this bug.

jst, do you want to land that patch?

Comment 7

[Reed Loden [:reed]]

Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.886; previous revision: 1.885
done

Comment 8

[Jesse Ruderman]

Crashtest checked in.