Closed Bug 403602 Opened 15 years ago Closed 15 years ago

Include "Download" string after "Cancel", "Pause", "Retry", and "Resume" context-menu items

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

VERIFIED WONTFIX

People

(Reporter: stephend, Assigned: whimboo)

References

Details

Attachments

(1 file, 2 obsolete files)

According to http://people.mozilla.com/~madhava/files/downloadmanager/downloadmanager_revision1.png (and its ilk at http://people.mozilla.com/~madhava/files/downloadmanager/), the following context-menu items should include "Download":
* Cancel (should read "Cancel Download")
* Retry (should read "Retry Download")
* Resume (should read "Resume Download")
Flags: in-litmus?
Whiteboard: [good first bug]
Requesting wanted-firefox3 because this blocks a wanted bug.
Blocks: 397655
Flags: blocking-firefox3?
This change has a hidden l10n impact. Localizers have to update their entities accordingly.
This doesn't necessarily need to be hidden. Just doing a entity name change from cmd.pause.label etc to cmd.pauseDownload.label, and you're fine.
You even forgot the Play menu entry.

I hope that I don't steal this bug from a real newbie. But while it's blocking Fx3 it should be fixed.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #288512 - Flags: review?(comrade693+bmo)
I missed Axels comment while filing the attachment. So please decide what's the best way in doing the change. I could come up with a follow-up patch.
Whiteboard: [good first bug]
Comment on attachment 288512 [details] [diff] [review]
Patch v1: Add Download to context menu entries

Like it's done in bug 330139 I will change the entity name.
Attachment #288512 - Attachment is obsolete: true
Attachment #288512 - Flags: review?(comrade693+bmo)
Attached patch Patch v2 (obsolete) — Splinter Review
I updated all entities, commands, and keys. Works without an JS error/warning.

The only thing I cannot test are the access keys. They don't work on OS X. Is there an already existing bug about this issue? Otherwise I'll file a new bug.
Attachment #288546 - Flags: review?(comrade693+bmo)
(In reply to comment #7)
> The only thing I cannot test are the access keys. They don't work on OS X. Is
> there an already existing bug about this issue? Otherwise I'll file a new bug.

Sorry, but the keys work. Under OS X I'm currently not able to open the context menu. That's why I can't control the download of a file. Is there a key combination?
Comment on attachment 288546 [details] [diff] [review]
Patch v2

global nit: line wrapping at 80 chars.

I'm really torn on renaming all our commands to cmd_[oldname]Download now.  It seems like a big waste.  I think I'm more inclined to go with the crappier name, but overall shorter format of cmd.[oldname].label2 and leave the accesskey as it was.
Attachment #288546 - Flags: review?(comrade693+bmo) → review-
Updated patch which only changes the cmd.[name].label to cmd.[name].label2 and don't touch anything else.
Attachment #288546 - Attachment is obsolete: true
Attachment #288631 - Flags: review?(comrade693+bmo)
Summary: Include "Download" string after "Cancel," "Retry," and "Resume" context-menu items → Include "Download" string after "Cancel", "Pause", "Retry", and "Resume" context-menu items
From irc, regarding whether attachment 288631 [details] [diff] [review] will break translate toolkit:

<friedel> Your suggestion (comment 3) should work fine, but the newest diff will pose problems.
<friedel> we won't be able to automatically assiciate the accesskeys with the label if it is not called .label or .title
<friedel> so doing cmd.pause2.label or cmd.pauseDownload.label (as you suggested) should be fine.
<friedel> Does that help?
<Pike>	but then they need to change all accesskey labels, too, right?
<friedel> Yes, the part of the entity name before .label and .accesskey must correspond to be able to know that they go together.
This doesn't block, and its probably WONTFIX.  We're waiting on a new mockup rev, but appending this string frankly doesn't make a lot of sense since its clear what the target is.
Flags: blocking-firefox3? → blocking-firefox3-
New new mockup won't have all these "Download" strings for pause, resume, cancel and retry per bug 397655 comment 27. 

=> WONTFIX
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Attachment #288631 - Flags: review?(comrade693+bmo)
Verified; sorry for your time spent, Henrik, but thanks all the same!
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus-
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.