Removal of GC thing callback

RESOLVED FIXED

Status

()

Core
JavaScript Engine
P4
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
6.67 KB, patch
brendan
: review+
brendan
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
With the bug 401687 fixed the GC thing callback infrastructure added to JS GC to support the cycle collector is no longer necessary and can be safely removed. It would be nice to do it before FF3 is released and GC thing callback becomes a part of public API.
Flags: blocking1.9?
(Assignee)

Updated

10 years ago
Blocks: 378742
(Assignee)

Comment 1

10 years ago
Created attachment 288554 [details] [diff] [review]
v1

The patch removes gcThingCallback and related code.
Attachment #288554 - Flags: review?(brendan)

Comment 2

10 years ago
Blocking with low priority so we get a clean public bug
Flags: blocking1.9? → blocking1.9+
Priority: -- → P4
Comment on attachment 288554 [details] [diff] [review]
v1

>Index: js/src/jsgc.c
>===================================================================

>@@ -2086,34 +2081,22 @@ gc_lock_traversal(JSDHashTable *table, J

>+    if (!IS_GC_MARKING_TRACER(trc)) {
>+        for (n = lhe->count - 1; n != 0; --n)
>+            JS_CALL_TRACER(trc, thing, traceKind, "locked object");
>     }

Note that since the cycle collector doesn't refcount it doesn't rely on this anymore either. Unless you want to keep it for other users feel free to drop it too.
(Assignee)

Comment 4

10 years ago
Created attachment 288677 [details] [diff] [review]
v2

The new version removes that "lock count transfer to the tracer".
Attachment #288554 - Attachment is obsolete: true
Attachment #288677 - Flags: review?(brendan)
Attachment #288554 - Flags: review?(brendan)
Comment on attachment 288677 [details] [diff] [review]
v2

Yay! Thanks.

/be
Attachment #288677 - Flags: review?(brendan) → review+

Updated

10 years ago
Attachment #288677 - Flags: approval1.9+
(Assignee)

Comment 6

10 years ago
I checked in the patch from comment 4 to CVS trunk:

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1195469790&maxdate=1195469824&who=igor%mir2.org
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.