Closed Bug 403871 Opened 17 years ago Closed 17 years ago

Make frame trees with i18n text readable

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

Details

Attachments

(1 file, 1 obsolete file)

For some reason frame tree dumps convert non-ASCII text in text frames to octal escapes. If they were Unicode escapes life would be so much easier.
Attached patch Patch (obsolete) — Splinter Review
Attachment #288819 - Flags: superreview?(roc)
Attachment #288819 - Flags: review?(roc)
Can't you use nsPrintfCString or PR_sprintf here instead of manually translating?
I suppose so, but I thought there was some benefit in being consistent. Feel free to quote Emerson at me :)
Attachment #288819 - Attachment is obsolete: true
Attachment #288825 - Flags: superreview?(roc)
Attachment #288825 - Flags: review?(roc)
Attachment #288819 - Flags: superreview?(roc)
Attachment #288819 - Flags: review?(roc)
Attachment #288825 - Flags: superreview?(roc)
Attachment #288825 - Flags: superreview+
Attachment #288825 - Flags: review?(roc)
Attachment #288825 - Flags: review+
Comment on attachment 288825 [details] [diff] [review]
Using nsPrintfCString

Debug-only change.
Attachment #288825 - Flags: approval1.9?
Comment on attachment 288825 [details] [diff] [review]
Using nsPrintfCString

a=release drivers.
Attachment #288825 - Flags: approval1.9? → approval1.9+
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: