40388 - Hitting the Stop button on a page with animated images deletes the images

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Simon Fraser [no longer active]]

Load the URL above, and hit the Stop button (even though the button looks 
disabled, it works). Note that the animation stops. Now refresh the window. Note 
that the animated images have all disappeared.

When you hit the Stop button, nsDocShell::Stop is called, and this end up calling 
nsFrameImageLoader::StopImageLoad(), which removes all the images.

We need to be able to stop animations, but keep the images around.

Comment 1

[Jesse Ruderman]

should the images be left in their current state, or should each one be reset 
to its first frame?

Comment 2

[Kevin McCluskey (gone)]

I'm able to reproduce the problem on WINNT. Setting platform to All.

Comment 3

[Kevin McCluskey (gone)]

I found the problem. The nsPresContext StartLoadImage looks at the mStopped 
and returns without an image. The StartLoadImage is used in 
nsCSSRendering::PaintBackground to get the image to tile when painting 
background images.

If I comment out the code to return when mStopped is set the page starts 
animating again after you resize the window. This is compatible with how Nav 4.x 
behaves. I.E 5 Does not restart the animation when resized which seems more 
reasonable.

NS_IMETHODIMP
nsPresContext::StartLoadImage(const nsString& aURL,
                              const nscolor* aBackgroundColor,
                              const nsSize* aDesiredSize,
                              nsIFrame* aTargetFrame,
                              nsIFrameImageLoaderCB aCallBack,
                              void* aClosure,
                              nsIFrameImageLoader** aResult)
{
/*
  if (mStopped) {
    if (aResult) {
      *aResult = nsnull;
    }
    return NS_OK;
  }
*/

I think the calling code in nsCSSRendering should use some other mechanism for 
getting the image to background tile or pass a flag to 
nsPresContext::StartLoadImage to indicate that it wants the image returned even 
if it stopped.

Re-assigning to dcone to determine what the best solution is.

Comment 4

[dcone (gone)]

*** Bug 38406 has been marked as a duplicate of this bug. ***

Comment 5

[dcone (gone)]

This bug has been marked future because we have determined that it is not 
critical for netscape 6.0.  If you feel this is an error, or if it blocks your 
work in some way -- please attach your concern to the bug for reconsideration.

Comment 6

[Simon Fraser [no longer active]]

Whoah. This is a serious issue, and I really think we should fix this. Users 
don't expect all their animated GIFs to disappear when they hit the Stop button.
Nominating for beta3.

Comment 7

[dcone (gone)]

The only reason this made the future list was because I was told to get my list 
down to 5-7 bugs.. this one is about 10 on my list.  If I fix those bugs this 
will be back on beta3.  I do know how to correct this on.. but there could be 
some API changes if after testing some other loading problems crop up.

Comment 8

[Kevin McCluskey (gone)]

Marking nsbeta3-

Comment 9

[Kevin McCluskey (gone)]

Added relnote keyword

Comment 10

[Reinout van Schouwen]

Well, currently (build 2001043022) the Stop button doesn't do anything to
animated gifs anymore (neither does Esc). Very annoying. Is a bug filed for that
yet?

Comment 11

[Jesse Ruderman]

[e-mail]: yes, see bug 70030, "Cannot stop animation with 
webNavigation.stop".

Comment 12

[Jeremy M. Dolan]

Dupe of Bug 64522? window.stop() makes backround/animated images not paint

Comment 13

[Jamie Zawinski]

In ns4, the stop button on a page with anim-gifs remained active as long as one
of the images was still animating.  If you hit stop, they all stopped animating,
and stayed on whatever frame they were at (they didn't disappear, they just
stopped moving.)

This was a very nice feature.  It meant I had the ability to stop thing from
blinking at me when I found them distracting, without having to turn off
anim-gifs globally (which can render some pages unreadable, e.g. when there's a
blank first frame.)

Maybe bug 70030 is relevant to this, I can't tell.

Comment 14

[dcone (gone)]

The url is not valid anylonger. But on pages with my animated GIFS.. I dont get
this problem.  Marking WFM.