1.03 KB, text/plain
798 bytes, text/plain
4.87 KB, patch
|Details | Diff | Splinter Review|
1.32 KB, patch
|Details | Diff | Splinter Review|
Currently the 1.8 branch and the trunk for search and rss readers for pa-IN are out of sync. Is the setup we have for 2.0 the right one? Should we make changes? Amanpreet, can you create a patch to backport the branch state onto the trunk for starters? We'd like to have all changes to search and RSS readers tracked by patches and bugs. Request review from me on the patch before checking it in, please? Affected are the files in pa-IN/browser/searchplugins and pa-IN/browser/chrome/browser-region/region.properties. Sorry for filing this bug too late for B1, but we should try to get it in for B2.
Created attachment 289094 [details] [diff] [review] Patch to review for plugin and region file
Attachment #289094 - Flags: review?(l10n)
hi Pike, can you please review, so we can move foward..
Comment on attachment 289094 [details] [diff] [review] Patch to review for plugin and region file Seems like these already landed on trunk, but after we had cut the relbranch. Given a post-mortem review on these. For future reference, please file bugs if you want to make search or rss reader changes, and get a review on those patches from me before landing them. Then those changes should be checked in with a check-in comment referencing the bug, the change and my review, so that the cvs history has the information on why what is were. Thanks.
Attachment #289094 - Flags: review?(l10n) → review+
i don't recall reviewing this either is there another dependency bug where changes were reviewed? thanks mic
ping? can i get a list of the current search plug-ins, RSS readers and RSS feed (live bookmark). thanks
Search (browser/searchplugins/list.txt: google yahoo-in eBay-in -- where can I find RSS reader or RSS Feed in source?
The RSS readers are in region.properties, currently we have Bloglines, Google, My Yahoo on both trunk and branch. The RSS feed is in bookmarks.html, and should remain unchanged at http://pa-IN.fxfeeds.mozilla.com/pa-IN/firefox/headlines.xml. That is currently redirected to our standard BBC feed, http://newsrss.bbc.co.uk/rss/newsonline_world_edition/front_page/rss.xml.
what I have recorded as what should be there are defaults for all i.e., search, RSS feed (live bookmark) and RSS Readers. Amanpreet, I'd like to suggest some changes to make your build even more relevant for Punjabi users. Search: For Yahoo - we can use Yahoo India instead of Yahoo.com. Check out bug 384408 where Hindi has used this instead. You can do the say for eBay-India I've been trying to find a local Punjabi search engine but not having luck. If you know of one we could add that in? Currently your search engines are google, yahoo and eBay We can add back in wikipedia, it appears they have a decent Punjabi version at: http://pa.wikipedia.org/ the only other specialized punjabi sites i've found are punjabi.net and punjabiworld but neither seems hugely popular in a broad sense or offers specific search capabilities. In terms of news sources, I'm not sure if the BBC feed is in Punjabi but I found a few other sites that offer news in Punjabi: http://www.punjabinews.org/ and Yahoo offers a local feed Let me know what you think
PS: We're already using the India versions for yahoo and ebay. http://meta.wikimedia.org/wiki/List_of_Wikipedias says that pa.wikipedia.org has some 300 articles, not sure if we should do that.
Punjabi: http://www.punjabinews.org/ is just copy of Yahoo news at this time, so no use to refer there, (also not popular). as comment #11, yahoo is somehow good use than anyone else, although its Punjabi is too bad to refer to any Punjabi People. (Wikipedia is better than it). Other Popular Punjabi Sites are: http://www.likhari.com/ http://www.globalpunjabi.com/ NEWS: http://punjabi.s7news.com/Punjabi_News-5.html (also provide RSS Feed for Punjabi, better than Yahoo)
cool. does punjabi.s7news.com have a contact page we can ask for their permission? If you think they are a better source of Punjabi new than Yahoo let's see if we can't add them as the Live Bookmark feed instead likhari - looks interesting (promoting language and literature) but doesn't seem to have a search mechanism. Same with globalpunjabi, to me it appears they are both a portal therefore not sure how we can incorporate as a search plug-in? thoughts?
ya, those have nothing to do with Search. yahoo is more reliable (means of availability) so, I agree to use Yahoo as default for news
ok great on yahoo. for other sites, we're in the process of finalizing a new set of Firefox3 launch pages where there may be an opportunity to localize one of those pages with links to those two punjabi sites you mention. when i have more information i'll send it to you. next - patch for new yahoo news feed and mic adds to the official records for change (in this case I'll send over a note to Yahoo letting them know we'll be doing this but don't think we need to wait on that to proceed)
The news feed doesn't need a patch, but a change in the server redirects. I'll need a url for the yahoo feed to do that, though. I think we should handle the new in-product pages and their content in a separate bug.
Whiteboard: needs-patch → needs feed url
Back in the game, Amanpreet, can you provide a link for the yahoo news feed?
it is here! http://in.punjabi.yahoo.com/rss/index.htm
Amanpreet, for the web-based protocol handlers, we'd like to use the en-US defaults for now. You ported over the 30 boxes for webcal:, but in the meantime, yahoo mail landed, too, could you create a patch to add that? Make sure to bump the defaultHandlersVersion as mentioned in the comment in region.properties, the result should look like http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser-region/region.properties&rev=&cvsroot=/cvsroot&mark=20-34. If there would be good alternatives for India and Punjabi in particular, feel free to file bugs on getting them included in a minor 3.0.x release. Thanks.
Whiteboard: needs-pike → needs-patch
Created attachment 314273 [details] [diff] [review] Patch for browser-region.properties as per Pike's comment
Attachment #314273 - Flags: review?(l10n)
Comment on attachment 314273 [details] [diff] [review] Patch for browser-region.properties as per Pike's comment r=me, please check in with a comment referencing this bug and my review, describing the change. Nit, could you add the trailing newline? Just go to the end of the file and hit enter once :-)
Attachment #314273 - Flags: review?(l10n) → review+
Marking this FIXED, with reference http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/2de8ce45a4d0/reference/HEAD/pa-IN/.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
sorry to reopen, because of bug 380785, we need to add wikipedia for punjabi. can you please make a patch to add that. i'm sorry to reopen for this. here information for how to do that Search is all (*) in browser/searchplugins. Task: Replace en.wikipedia.org with pa.wikipedia.org. So, first, we need a plugin for the latter, for which a good name will be wikipedia-pa.org. You should create this by following what we do for en-US closely, that one is at http://mxr.mozilla.org/mozilla/source/browser/locales/en-US/searchplugins/wikipedia.xml. Use that as a template, and change the Urls accordingly, and use the link title of the rel="search" link on your wikipedia site as ShortName. That matches what the site sends, so Firefox will detect that it already has the search plugin. So, now you have the plugin in pa/browser/searchplugins/wikipedia-pa.xml, and to get it picked up, you replace the wikipedia with wikipedia-pa in list.txt. To create the patch, do, in browser/searchplugins cvs add wikipedia-pa.xml cvs -z3 diff -uN and attach the output here, and mark it as patch, there's a checkbox for that. To request review on that, set the "Review" flag to '?', and the requestee to my bugzilla ID. (*) The search ordering stuff is in region.properties, too, but that's changed rarely.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We decided to not block shipping on wikipedia, filed follow-up bug 428397. Resolving this FIXED again, with reference http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/467ee9f84f02/reference/HEAD/pa-IN/.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.