403953 - Enable the Address Book property dialogs to be address book type specific without nasty hacks.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Currently if you're not an LDAP directory, then you have to use the standard "rename only" dialog for your address book properties (or do some really horrible overloading).

The patch I'm attaching provides a read only attribute in nsIAbDirectory (propertiesChromeURI) that returns the URI for the purpose of displaying the dialog. This should help future dev.

I was going to do this attribute/function so that it would display the dialog in the c++. Then I found out that to do it would require many more lines than doing it in the js - so I opted for the simpler solution.

I'm not fussed about the new directory functions at the moment, we'd have to have a way of getting the properties from the factory, probably via nsIAddressBook, and we're not really set up for that at the moment. Additionally, its a lot easier to provide an overlay which calls the required new function than it is for the edit/properties functions.

Patch does the required changes for TB & SM.

Comment 1

[David :Bienvenu]

Comment on attachment 288882 [details] [diff] [review]
The fix

this looks OK to me, as long as Neil likes it :-)

Comment 2

[[e-mail]]

Comment on attachment 288882 [details] [diff] [review]
The fix

You never actually override the property for LDAP address books so they can't be edited from the main addressbook window with this patch...

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> (From update of attachment 288882 [details] [diff] [review])
> You never actually override the property for LDAP address books so they can't
> be edited from the main addressbook window with this patch...

Well I do in my local build ;-) Sorry, obviously missed that file from the patch. I'll attach a new one later.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix v2

Corrected patch with the LDAP override this time...

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix v3

Lets see if I can get it right this time...

Comment 6

[Mark Banner (:standard8)]

Patch checked in. Fixed.

Comment 7

[Joe Sabash [:JoeS1]]

Mark, FWIW it looks like you transposed the bug numbers in the checkin description