403994 - Don't install nss headers when system-nss is used

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Fabien Tassin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111523 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111523 Minefield/3.0b2pre

bug 389872 started to install nss headers inconditionally. It makes the build fail on some platforms (firefox, xulrunner and seamonkey).

make[4]: Entering directory `/build/buildd/seamonkey-2.0/security/manager'
/build/buildd/seamonkey-2.0/config/nsinstall -D ../../dist/include/nss
(cd ../../dist/public/nss && tar -cvhf - .) | \
	  (cd ../../dist/include/nss && tar -xf -)
cd: 2: can't cd to ../../dist/public/nss
tar: This does not look like a tar archive
tar: Error exit delayed from previous errors
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/build/buildd/seamonkey-2.0/security/manager'

Strangely, on other platforms, it's not fatal:

(cd ../../dist/public/nss && tar -cvhf - .) | \
	  (cd ../../dist/include/nss && tar -xf -)
cd: 2: can't cd to ../../dist/public/nss
(cd ../../dist/public/nss && tar -cvhf - .) | \
	  (cd ../../dist/sdk/include && tar -xf -)
cd: 2: can't cd to ../../dist/public/nss
/usr/bin/make -C boot libs
...

in both case, /bin/sh is in fact dash, but not the same version.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Fabien Tassin]

Attachment: protect install by MOZ_NATIVE_NSS ifdef

Comment 2

[Robert Relyea]

Comment on attachment 288937 [details] [diff] [review]
protect install by MOZ_NATIVE_NSS ifdef

Yes, you don't want to bring in these headers if you are using system NSS (which may have a newer version of NSS than included in these source file).

Comment 3

[Reed Loden [:reed]]

Comment on attachment 288937 [details] [diff] [review]
protect install by MOZ_NATIVE_NSS ifdef

Simple build fix for Linux distros who wish to use system NSS instead of the shipped NSS.

Comment 4

[Reed Loden [:reed]]

Checking in security/manager/Makefile.in;
/cvsroot/mozilla/security/manager/Makefile.in,v  <--  Makefile.in
new revision: 1.79; previous revision: 1.78
done