404134 - Allow XULRunner apps to override name & vendor

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

XULRunner applications, like Prism, try to simulate many different applications but are really the same XUL application launched with different flags. However, the toolkit considers each launch to be part of the same process. On Mac, the toolkit refuses to load additional launches because of this.

We could explore ways to allow XUL apps to override the Name & Vendor of their application.ini, which would convince the system that this instance is not the same as any other running instance. There is already a simple use of override.ini to disable profile migration. The plan is to extend override.ini to allow changing the Name and Vendor properties too.

This would also allow each launch to have separate profiles, without resorting to playing with -P or -profile.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Adds Name and Vendor override capability to xulrunner and xulrunner-stub

This patch adds a simple override of Name and Vendor. The path to the override is passed on the commandline (it is not assumed to be in a known folder).

BSmedberg - I'm not entirely happy the "Override" method and the "SetAllocatedString" function are duplicated. I could move the "Override" code to act like the XRE_CreateAppData / XRE_ParseAppData -> XRE_OverrideAppData, if you feel it is needed.

Also, this patch only addresses XULRunner launching. Firefox -app launching will need to be fixed similarly, but I wanted to handle that in a separate patch.

Comment 2

[Benjamin Smedberg]

Comment on attachment 289112 [details] [diff] [review]
Adds Name and Vendor override capability to xulrunner and xulrunner-stub

I really don't think you need to duplicate all this code.... can't you just call XRE_ParseAppData(ovrDataLF, appData)?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: same as previous patch but using XRE_ParseAppData to avoid dupe code

Using XRE_ParseAppData does remove some duped code

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Checking in app/nsXULRunnerApp.cpp;
/cvsroot/mozilla/xulrunner/app/nsXULRunnerApp.cpp,v  <--  nsXULRunnerApp.cpp
new revision: 1.37; previous revision: 1.36
done
Checking in stub/nsXULStub.cpp;
/cvsroot/mozilla/xulrunner/stub/nsXULStub.cpp,v  <--  nsXULStub.cpp
new revision: 1.11; previous revision: 1.10
done

Comment 5

[Reed Loden [:reed]]

Can this bug be resolved as fixed? Patch was checked-in...