Use NS_GetReferrerFromChannel

RESOLVED WONTFIX

Status

Core Graveyard
Installer: XPInstall Engine
RESOLVED WONTFIX
11 years ago
3 years ago

People

(Reporter: sdwilsh, Unassigned)

Tracking

unspecified
mozilla1.9beta2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [needs feedback])

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
There's a bit of code that grabs the referrer.  Netwerk now has a util method for that once Bug 401174 lands.
(Reporter)

Comment 1

11 years ago
Created attachment 289194 [details] [diff] [review]
v1.0
Attachment #289194 - Flags: superreview?(benjamin)
Attachment #289194 - Flags: review?(benjamin)
(Reporter)

Updated

11 years ago
Whiteboard: [has patch][needs r bsmedberg][needs sr bsmedberg]
Target Milestone: --- → mozilla1.9 M10

Updated

11 years ago
Attachment #289194 - Flags: superreview?(dveditz)
Attachment #289194 - Flags: superreview?(benjamin)
Attachment #289194 - Flags: review?(benjamin)
Attachment #289194 - Flags: review+
(Reporter)

Updated

11 years ago
Whiteboard: [has patch][needs r bsmedberg][needs sr bsmedberg] → [has patch][has r][needs sr dveditz]
Comment on attachment 289194 [details] [diff] [review]
v1.0

I think the name of the helper function will mislead people into doing the wrong thing (see bug 401174 comment 25).

I also worry about the function's fallback to using the real referrer if the property isn't found, I have a nagging feeling I didn't do that on purpose here.
(Reporter)

Comment 3

11 years ago
So, is this bug WONTFIX then?
(Reporter)

Updated

11 years ago
Whiteboard: [has patch][has r][needs sr dveditz] → [needs feedback]
(Reporter)

Updated

10 years ago
Assignee: sdwilsh → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
Attachment #289194 - Flags: superreview?(dveditz)
(Assignee)

Updated

3 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.