Steps to reproduce: 1. Load http://www.squarefree.com/start/. 2. Cmd+Shift+I to open DOM Inspector. Result: ###!!! ASSERTION: Wrong display struct?: 'aStyleDisplay == aNewFrame->GetStyleDisplay()', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1398
11 years ago
Component: DOM Inspector → Layout
Product: Other Applications → Core
QA Contact: dom-inspector → layout
Created attachment 289245 [details] [diff] [review] Possible fix The issue is that nsSplitterFrame's Init() method changes its style context. So the display struct no longer matches. This patch just makes us get the display struct off the frame in AddChild() instead of passing one in. The other options are to remove the assert, or to reget the display struct in the XUL frame construction code after doing InitAndRestoreFrame. Thoughts?
11 years ago
Summary: "ASSERTION: Wrong display struct?" when opening DOM Inspector → [FIX]"ASSERTION: Wrong display struct?" when opening DOM Inspector
Comment on attachment 289245 [details] [diff] [review] Possible fix this approach looks good to me
Comment on attachment 289245 [details] [diff] [review] Possible fix Simple fix to make sure that the information we pass is always consistent, even in the face of XUL suckage.
Attachment #289245 - Flags: approval1.9?
Checked in. Could use standalone testcase...
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
I checked in Martijn's testcase as a crashtest.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.