Closed
Bug 404327
Opened 17 years ago
Closed 17 years ago
Remove unused gopher files on update
Categories
(Firefox Build System :: General, defect, P2)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla3 beta2
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file)
1.42 KB,
patch
|
ted
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
Since bug 273459, we no longer ship these files res/html/gopher-audio.gif res/html/gopher-binary.gif res/html/gopher-find.gif res/html/gopher-image.gif res/html/gopher-menu.gif res/html/gopher-movie.gif res/html/gopher-sound.gif res/html/gopher-telnet.gif res/html/gopher-text.gif res/html/gopher-unknown.gif They are in the Firefox 3.0a8 release, but not 3.0b1rc3. During a test update between those two versions the files weren't removed, so we should add them to removed-files.in - then everything stays in sync: new installs, over-the-top installs, updated isntalls. Including Thunderbird so that it doesn't get missed, and CC'ing Calendar & Suite for the matching changes.
Assignee | ||
Comment 1•17 years ago
|
||
Sorry for the spam, off by one for the Component.
Assignee: nrthomas → nobody
Component: Disability Access → Build Config
Priority: -- → P2
QA Contact: disability.access → build.config
Assignee | ||
Comment 2•17 years ago
|
||
Assignee: nobody → nrthomas
Status: NEW → ASSIGNED
Attachment #289304 -
Flags: review?(ted.mielczarek)
Updated•17 years ago
|
Attachment #289304 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Comment on attachment 289304 [details] [diff] [review] add to removed-files.in This is a cleanup for updates and over the top installs for trunk builds. We haven't shipped these files in Firefox (and other) nightlies for more than a month, no bugs filed since then with gopher in the comment.
Attachment #289304 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #289304 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 4•17 years ago
|
||
Checking in browser/installer/removed-files.in; /cvsroot/mozilla/browser/installer/removed-files.in,v <-- removed-files.in new revision: 1.30; previous revision: 1.29 done Checking in mail/installer/removed-files.in; /cvsroot/mozilla/mail/installer/removed-files.in,v <-- removed-files.in new revision: 1.37; previous revision: 1.36 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M10
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•5 years ago
|
Target Milestone: Firefox 3 beta2 → mozilla3 beta2
You need to log in
before you can comment on or make changes to this bug.
Description
•