404336 - resource://gre/res/html/folder.png should be skinnable, and move to chrome://global/skin

Status: RESOLVED WONTFIX

(Core Graveyard :: Networking: FTP, defect)

Description

[Alfred Kayser]

resource://gre/res/html/folder.png should be skinnable, and move to chrome://global/skin.

Currently within the /res/html folder in the application path, folder.png is only remaining file (after bug 294800 and bug 404327), so we can remove /res/html completely by moving folder.png to chrome.

The only two users are:
/netwerk/streamconv/converters/nsIndexedToHTML.cpp, line 354 -- " content: url(resource://gre/res/html/folder.png);\n"
/layout/html/tests/block/bugs/17636.html, line 9 -- &nbsp;&nbsp;&nbsp;<img alt="Diamond Home Page Header Logo" height="82" src="resource://gre/res/html/folder.png" width="83"><img border="0" height="82" isMap

Both could be changed by referring to:
chrome://global/skin/dirListing/local.png

Note, also the following needs to be fixed:
/layout/build/layout.pkg, line 45 -- dist/bin/res/html/folder.png

And like bug 404327, when this is done, /res/html/folder.png can then be removed from the distribution/installation.

Comment 1

[Patrick McManus [:mcmanus]]

We are in a period where ftp is clearly deprecated and in general, making changes to the code is riskier than letting it ride unless there is a patch and reviewer available to make a good judgment about it. So I'm going to wontfix ftp bugs related to enhancements, interop errors, etc.. We will be better off putting our energy into including a different js based ftp stack.