JavaScript Tests - handle "race" in some Date tests

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
x86
All
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 289332 [details] [diff] [review]
patch

The following tests include comparisons of (new Date()).toString() vs Date(...). These can fail randomly if the second changes between the times of the two calls. 

ecma/Date/15.9.2.1.js
ecma/Date/15.9.2.2-1.js
ecma/Date/15.9.2.2-2.js
ecma/Date/15.9.2.2-4.js
ecma/Date/15.9.2.2-6.js

The following tests have incorrect headers written to the log.

ecma/Date/15.9.1.1-1.js
ecma/Date/15.9.1.1-2.js
Flags: in-testsuite-
Flags: in-litmus-
(Assignee)

Comment 1

10 years ago
Checking in ecma/Date/15.9.1.1-1.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.1.1-1.js,v  <--  15.9.1.1-1.js
new revision: 1.6; previous revision: 1.5
done
Checking in ecma/Date/15.9.1.1-2.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.1.1-2.js,v  <--  15.9.1.1-2.js
new revision: 1.6; previous revision: 1.5
done
Checking in ecma/Date/15.9.2.1.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.1.js,v  <--  15.9.2.1.js
new revision: 1.7; previous revision: 1.6
done
Checking in ecma/Date/15.9.2.2-1.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.2-1.js,v  <--  15.9.2.2-1.js
new revision: 1.7; previous revision: 1.6
done
Checking in ecma/Date/15.9.2.2-2.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.2-2.js,v  <--  15.9.2.2-2.js
new revision: 1.7; previous revision: 1.6
done
Checking in ecma/Date/15.9.2.2-4.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.2-4.js,v  <--  15.9.2.2-4.js
new revision: 1.7; previous revision: 1.6
done
Checking in ecma/Date/15.9.2.2-6.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.2-6.js,v  <--  15.9.2.2-6.js
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

10 years ago
I missed these two files:

Checking in 15.9.2.2-3.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.2-3.js,v  <--  15.9.2.2-3.js
new revision: 1.7; previous revision: 1.6
done
Checking in 15.9.2.2-5.js;
/cvsroot/mozilla/js/tests/ecma/Date/15.9.2.2-5.js,v  <--  15.9.2.2-5.js
new revision: 1.7; previous revision: 1.6
done
You need to log in before you can comment on or make changes to this bug.