404406 - Make MathML attribute mapping content-based

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

To make things a bit more sane, I've reimplemented MathML attribute-style mapping in content with a new nsMathMLElement. This lays the groundwork for style system support for scriptlevel, scriptminsize and scriptsizemultiplier.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

-- Refactor attribute-mapping logic from nsGenericHTMLElement into a new base class nsMappedAttributeElement.
-- Inherit from that class to new nsMathMLElement
-- Implement MathML attribute mapping logic there
-- Also implement mapping logic for scriptlevel, scriptminsize, scriptsizemultiplier (currently the ruledata is unused, I'm fixing that next)
-- The new mapping logic restricts attributes to the elements for which the MathML REC says they should apply; the old logic did not.
-- Remove attribute mapping logic from MathML frames
-- Reftest; currently the test does not actually test anything, because none of the MathML elements render due to layout bugs karlt is working on. But I verified that things are OK via the DOM Inspector.

David, if you want someone else to review this (Jonas?) let me know.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: updated patch

That patch was missing some changes to dom/. Also, this update makes the new members of nsCSSFont #ifdef MOZ_MATHML.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 289430 [details] [diff] [review]
updated patch

My attempts to separate this from work on bug 355548 kinda failed. I'm just going to post a big patch there.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by 355548, basically.