Make MathML attribute mapping content-based

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

To make things a bit more sane, I've reimplemented MathML attribute-style mapping in content with a new nsMathMLElement. This lays the groundwork for style system support for scriptlevel, scriptminsize and scriptsizemultiplier.
Created attachment 289396 [details] [diff] [review]
fix

-- Refactor attribute-mapping logic from nsGenericHTMLElement into a new base class nsMappedAttributeElement.
-- Inherit from that class to new nsMathMLElement
-- Implement MathML attribute mapping logic there
-- Also implement mapping logic for scriptlevel, scriptminsize, scriptsizemultiplier (currently the ruledata is unused, I'm fixing that next)
-- The new mapping logic restricts attributes to the elements for which the MathML REC says they should apply; the old logic did not.
-- Remove attribute mapping logic from MathML frames
-- Reftest; currently the test does not actually test anything, because none of the MathML elements render due to layout bugs karlt is working on. But I verified that things are OK via the DOM Inspector.

David, if you want someone else to review this (Jonas?) let me know.
Attachment #289396 - Flags: superreview?(dbaron)
Attachment #289396 - Flags: review?(dbaron)
Created attachment 289430 [details] [diff] [review]
updated patch

That patch was missing some changes to dom/. Also, this update makes the new members of nsCSSFont #ifdef MOZ_MATHML.
Attachment #289396 - Attachment is obsolete: true
Attachment #289430 - Flags: superreview?(dbaron)
Attachment #289430 - Flags: review?(dbaron)
Attachment #289396 - Flags: superreview?(dbaron)
Attachment #289396 - Flags: review?(dbaron)
Comment on attachment 289430 [details] [diff] [review]
updated patch

My attempts to separate this from work on bug 355548 kinda failed. I'm just going to post a big patch there.
Attachment #289430 - Flags: superreview?(dbaron)
Attachment #289430 - Flags: review?(dbaron)
Fixed by 355548, basically.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-

Updated

10 years ago
Component: DOM: Core → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.