Closed
Bug 404500
Opened 17 years ago
Closed 16 years ago
add localized description for DOMi
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: wladow, Assigned: wladow)
Details
Attachments
(2 files)
874 bytes,
patch
|
sdwilsh
:
review+
neil
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
868 bytes,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9b2pre) Gecko/2007111805 Minefield/3.0b2pre Build Identifier: We should add localized description for DOMi extension. There are 2 possible ways: Localizing in Gecko 1.9 - http://developer.mozilla.org/en/docs/Localizing_extension_descriptions#Localizing_in_Gecko_1.9 Localizing before Gecko 1.9 - http://developer.mozilla.org/en/docs/Localizing_extension_descriptions#Localizing_before_Gecko_1.9 If we are going to use "Localizing in Gecko 1.9" - probably we should, as trunk DOMi is working only with gecko 1.9 based apps - localizers need to patch install.rdf with small block of text - no implementation patch needed. If we are going to use "Localizing before Gecko 1.9", description will move into locale files and patch is needed for implementation. Reproducible: Always
Assignee | ||
Updated•17 years ago
|
Version: unspecified → Trunk
Assignee | ||
Comment 1•16 years ago
|
||
Shawn, what do you think about this? I used an approach introduced by Gecko1.9, where you can add localized extension decription directly to install.rdf file and you don't need to patch any other files. Each localization team can use this way to add their own description.
Attachment #296765 -
Flags: review?(comrade693+bmo)
Comment 2•16 years ago
|
||
Assuming it works, it looks good to me. Out of curiosity, why isn't "DOM Inspector" localized?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•16 years ago
|
||
Our (means Slovak Localization Team) policy is to let extensions names untranslated.
Assignee | ||
Comment 4•16 years ago
|
||
Shawn, can we get this in to make b3? Or what else is needed to get r+? I suggest to move this bug into l10n component, what do you think?
Comment 5•16 years ago
|
||
sorry - I'll get to it soon. DOMi is supposed to be removed from the default build soon too...
Comment 6•16 years ago
|
||
Comment on attachment 296765 [details] [diff] [review] add slovak localizated description to DOMi r=sdwilsh
Attachment #296765 -
Flags: superreview?(neil)
Attachment #296765 -
Flags: review?(sdwilsh)
Attachment #296765 -
Flags: review+
Updated•16 years ago
|
Assignee: nobody → valastiak
Comment 7•16 years ago
|
||
Comment on attachment 296765 [details] [diff] [review] add slovak localizated description to DOMi >+ <em:localized> >+ <Description> >+ <em:locale>sk</em:locale> >+ <em:name>DOM Inspector</em:name> >+ <em:description>Umožní preskúmať štruktúru a vlastnosti okna a jeho obsahu.</em:description> >+ </Description> >+ </em:localized> >+ > <em:name>DOM Inspector</em:name> > <em:description>Inspects the structure and properties of a window and its contents.</em:description> > <em:creator>mozilla.org</em:creator> ...I think that the en-US description should be first ;-)
Attachment #296765 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 8•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Attachment #296765 -
Flags: approval1.9?
Comment 9•16 years ago
|
||
Comment on attachment 296765 [details] [diff] [review] add slovak localizated description to DOMi a1.9+=damons
Attachment #296765 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9 M11
Comment 10•16 years ago
|
||
Checking in extensions/inspector/install.rdf; /cvsroot/mozilla/extensions/inspector/install.rdf,v <-- install.rdf new revision: 1.16; previous revision: 1.15 done
You need to log in
before you can comment on or make changes to this bug.
Description
•