Closed Bug 404514 Opened 17 years ago Closed 17 years ago

Native GTK active button look

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: micmon, Assigned: twanno)

References

Details

Attachments

(2 files)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112004 Minefield/3.0b2pre Right now "active" buttons such as activated bookmark and history buttons in the toolbar or the search buttons in places are not very well distinguishable from the rest. Plain GTK makes the button stand out more (by keeping the pressed look), see screenshot. Reproducible: Always
Attached image Comparison Screenshot
See also Bug 381206
Status: UNCONFIRMED → NEW
Component: OS Integration → Widget: Gtk
Ever confirmed: true
Product: Firefox → Core
QA Contact: os.integration → gtk
Version: unspecified → Trunk
Draws a depressed GtkToggleButton, when a button is open/checked. This should be the correct bug
Assignee: nobody → twanno
Status: NEW → ASSIGNED
Attachment #291125 - Flags: superreview?(roc)
Attachment #291125 - Flags: review?(roc)
Attachment #291125 - Flags: superreview?(roc)
Attachment #291125 - Flags: superreview+
Attachment #291125 - Flags: review?(roc)
Attachment #291125 - Flags: review+
Comment on attachment 291125 [details] [diff] [review] makes pressed buttons look native Another fix to make Firefox on Linux more integrated.
Attachment #291125 - Flags: approval1.9?
Attachment #291125 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in toolkit/themes/gnomestripe/global/toolbarbutton.css; /cvsroot/mozilla/toolkit/themes/gnomestripe/global/toolbarbutton.css,v <-- toolbarbutton.css new revision: 1.15; previous revision: 1.14 done Checking in widget/src/gtk2/gtk2drawing.c; /cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v <-- gtk2drawing.c new revision: 1.45; previous revision: 1.44 done Checking in widget/src/gtk2/gtkdrawing.h; /cvsroot/mozilla/widget/src/gtk2/gtkdrawing.h,v <-- gtkdrawing.h new revision: 1.39; previous revision: 1.38 done Checking in widget/src/gtk2/nsNativeThemeGTK.cpp; /cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v <-- nsNativeThemeGTK.cpp new revision: 1.116; previous revision: 1.115 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: