404514 - Native GTK active button look

Status: RESOLVED FIXED

Description

[Michael Monreal [:micmon]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112004 Minefield/3.0b2pre

Right now "active" buttons such as activated bookmark and history buttons in the toolbar or the search buttons in places are not very well distinguishable from the rest. Plain GTK makes the button stand out more (by keeping the pressed look), see screenshot.

Reproducible: Always

Comment 1

[Michael Monreal [:micmon]]

Created attachment 289487 [details]
Comparison Screenshot

Comment 2

[Jeremy Baron]

See also Bug 381206

Comment 3

[Teune van Steeg]

Created attachment 291125 [details] [diff] [review]
makes pressed buttons look native

Draws a depressed GtkToggleButton, when a button is open/checked.

This should be the correct bug

Comment 4

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 291125 [details] [diff] [review]
makes pressed buttons look native

Another fix to make Firefox on Linux more integrated.

Comment 5

[Reed Loden [:reed] (use needinfo?)]

Checking in toolkit/themes/gnomestripe/global/toolbarbutton.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/toolbarbutton.css,v  <--  toolbarbutton.css
new revision: 1.15; previous revision: 1.14
done
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.45; previous revision: 1.44
done
Checking in widget/src/gtk2/gtkdrawing.h;
/cvsroot/mozilla/widget/src/gtk2/gtkdrawing.h,v  <--  gtkdrawing.h
new revision: 1.39; previous revision: 1.38
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.116; previous revision: 1.115
done