404519 - some margin and edges twips/app units confusion

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: patch

Follow-up from bug 396278 comment 22:

There are some remaining places where the margins/edge values aren't converted to app units. Attached patch (adapted from attachment 288868 [details] [diff] [review] from bug 396278 by Jeremy Lea) should fix these.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 289490 [details] [diff] [review]
patch

Looks good.

Comment 2

[Reed Loden [:reed]]

Checking in layout/base/nsDocumentViewer.cpp;
/cvsroot/mozilla/layout/base/nsDocumentViewer.cpp,v  <--  nsDocumentViewer.cpp
new revision: 1.555; previous revision: 1.554
done
Checking in layout/generic/nsSimplePageSequence.cpp;
/cvsroot/mozilla/layout/generic/nsSimplePageSequence.cpp,v  <--  nsSimplePageSequence.cpp
new revision: 3.161; previous revision: 3.160
done
Checking in layout/generic/nsSimplePageSequence.h;
/cvsroot/mozilla/layout/generic/nsSimplePageSequence.h,v  <--  nsSimplePageSequence.h
new revision: 3.60; previous revision: 3.59
done
Checking in layout/printing/nsPrintEngine.cpp;
/cvsroot/mozilla/layout/printing/nsPrintEngine.cpp,v  <--  nsPrintEngine.cpp
new revision: 1.158; previous revision: 1.157
done

Comment 3

[Reed Loden [:reed]]

Thanks reg / chpe for the patch! Anything to help the horrors of printing is greatly appreciated. :)