404539 - jsDriver.pl -K fails to report errors

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

From bug 404499 comment 2

I have not seen the regression because the driver does not report the failures
even if the output comes with errors:

~/m/trunk/mozilla/js/tests $ ./jsDriver.pl -e smdebug -l
js1_5/Regress/regress-168347.js -K
-#- Executing 1 test(s).
-#- Wrote results to 'results-2007-11-20-161256-smdebug.html'.
-#- 0 test(s) failed

Comment 1

[Bob Clary [:bc] (inactive)]

err, I meant -K didn't show the error but -R does. doh. 

Comment 2

[Igor Bukanov]

The biggest issue for me is that the failure is not included into the list of failed test cases as I diff against such list to check for regressions. 

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: patch

Igor, this should fix it.

Comment 4

[Bob Clary [:bc] (inactive)]

Checking in jsDriver.pl;
/cvsroot/mozilla/js/tests/jsDriver.pl,v  <--  jsDriver.pl
new revision: 1.73; previous revision: 1.72
done

Igor, I am really sorry this didn't work for you. The regression is entirely my fault.