Closed Bug 404590 Opened 15 years ago Closed 15 years ago

Figure out NSIS UNICODE / ANSI side by side in MozillaBuild

Categories

(mozilla.org :: MozillaBuild, task)

x86
Windows Vista
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: ted)

References

Details

Attachments

(1 file, 1 obsolete file)

We need a method to provide both the UNICODE and ANSI versions of NSIS in MozillaBuild
Blocks: 406085
No longer blocks: 394044
Which would be the versions? Ted and I found stuff on http://www.scratchpaper.com/, and a ticket pointing there on https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1795257&group_id=22049
Attached patch untested patch (obsolete) — Splinter Review
Simple packaging bits to add the unicode build of NSIS.  I've also added the nsis-2.33u.zip here, which is just the unicode build from the above website, with makensis.exe renamed to makensisu.exe as per Rob Strong.  I'll build a new MozillaBuild with this for testing soon.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Comment on attachment 291676 [details] [diff] [review]
untested patch

Well, despite not testing it, it's a pretty simple patch.  bhearsum is still working on getting a working build of MozillaBuild going, so we should probably just roll with this.
Attachment #291676 - Flags: review?(benjamin)
Comment on attachment 291676 [details] [diff] [review]
untested patch

As discussed on IRC, I'd like the checked-in zipfile to be the stock distribution; we should do the makensis -> makensisu renaming at packageit time.
Attachment #291676 - Flags: review?(benjamin) → review-
Going to spin a build with this shortly.
Attachment #291676 - Attachment is obsolete: true
Attachment #292848 - Flags: review?(benjamin)
I built an installer with this, but it's busted from some other changes.  Will respin tomorrow.

http://people.mozilla.com/~tmielczarek/MozillaBuildSetup-nsis.exe

Ok, this has makensisu.exe in it as well as some other patches.  It's pretty close to being 1.2rc1 actually, but it's missing bhearsum's ssh update patch.  I get a working shell with this, but I haven't tried building Mozilla with it, so no guarantees yet.
Attachment #292848 - Flags: review?(benjamin) → review+
Checked in.  Release candidate forthcoming.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: Build & Release → MozillaBuild
Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild
QA Contact: build → mozillabuild
You need to log in before you can comment on or make changes to this bug.