404632 - Fix various bugs in key down handling, make it more clean and efficient

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P4)

Description

[Josh Aas]

Attachment: fix v1.0

While working on Cocoa key handling blockers I ended up with some general fixes we should take.

A pile of fixes to our key down handling code has left it in a somewhat messy state. This patch fixes the following problems:

1. mIgnoreDoCommand is incorrectly set in the fake key down event code we have in keyUp:
2. Focus changes aren't calculated correctly. We shouldn't be making assumptions about the first responder, test for focus changes explicitly.
3. If we bail because of a focus change, make sure to reset *all* of the member state variables that we modified. This doesn't matter if we bail because we were destroyed, so not changing that case.
4. Better variable names and test structure. We can do things more efficiently (via better scoping) when the logic is coded more clearly.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 289549 [details] [diff] [review]
fix v1.0

looks good for me.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 289549 [details] [diff] [review]
fix v1.0

Looks like you could save some space in nsChildView by packing bools (PRPackedBool, not bitfields), but we don't have to do that here.

Comment 3

[Josh Aas]

landed on trunk