404636 - Building without SVG fails

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Possible fix

Building without SVG fails 
http://mxr.mozilla.org/seamonkey/source/layout/generic/nsLineLayout.cpp#763

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You need to #ifdef just the SVG line. the subDocumentFrame check needs to stay there.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Minimal define

Comment 3

[Reed Loden [:reed]]

Comment on attachment 289618 [details] [diff] [review]
Minimal define

This isn't the right patch.

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Minimal define 2

Ups, previous attachment was the same....

Comment 5

[Reed Loden [:reed]]

Comment on attachment 289619 [details] [diff] [review]
Minimal define 2

Simple patch to allow building layout without SVG.

Comment 6

[Reed Loden [:reed]]

Please don't add checkin-needed until the patch has approval. All patches either need approval1.9+ or the bug must be blocking1.9+/blocking-firefox3+ in order to land.

Comment 8

[Reed Loden [:reed]]

Checking in layout/generic/nsLineLayout.cpp;
/cvsroot/mozilla/layout/generic/nsLineLayout.cpp,v  <--  nsLineLayout.cpp
new revision: 3.285; previous revision: 3.284
done