40465 - install script dies unexpectedly on getFolder(null)

Status: RESOLVED WONTFIX

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 2000-05-24-09-M16(WIN), 2000-05-24-08-M16(LINUX), Mac is blocked by Bug 
38989

1. From http://jimbob/trigger3.html, click on Functional drop-down menu and
   choose f_getfolder_paths
2. Click Trigger case button
3. Click Ok button from confirmation dialog

RESULT:
The install.log writes out some paths, but not all.  This used to work. -229 
appears from install.log.

EXPECTED RESULT:
All paths appear from log.  -229 does not appear from install.log.

NOTE:
The other bug fixes related to -229 do not appear to affect this test case.  
Also, I commented all the calls to "showPath" from the install script, and the 
-229 still appeared from the install.log.  This bug is important to fix because 
I cannot properly verify or reopen Bug 23289.

INSTALL.LOG:
-------------------------------------------------------------------------------
http://jimbob/jars/f_getfolder_paths.xpi  --  05/24/2000 13:15:17
-------------------------------------------------------------------------------

     Functional: f_getfolder_paths
     -----------------------------

     ** targetFolder = Chrome
     ** getFolder returns = C:\Program Files\Netscape\Netscape 6\chrome\
     ** targetFolder = Communicator
     ** getFolder returns = C:\Program Files\Netscape\Netscape 6\
     ** targetFolder = Components
     ** getFolder returns = C:\Program Files\Netscape\Netscape 6\components\
     ** targetFolder = Current User
     ** getFolder returns = C:\Program Files\Netscape\Users50\default\

     Install **FAILED** with error -229

     Install **FAILED** with error -229
     Finished Installation  05/24/2000 13:15:17

INSTALL SCRIPT:
////////////////////////////////////////////////////////////////////////////////
// f_getfolder_paths.js
// 
// Functional test
// 	• Checks the path form returned with getFolder() for all target folders
//
// ~ XPInstall QA
//   October 5, 1999. Jimmy Lee. Created.
//   March 31, 2000. David Epstein. Renamed API.
//
////////////////////////////////////////////////////////////////////////////////

function showPath(targetFolder) 
{
	f = getFolder(targetFolder);
	logComment("targetFolder = " + targetFolder);
	logComment("getFolder returns = " + f);
}

initInstall("Functional: f_getfolder_paths", "f_getfolder_paths", "1.1.1.1", 0);
showPath("Chrome");
showPath("Communicator");
showPath("Components");
showPath("Current User");
showPath("file:///");
showPath("OS Drive");
showPath("Plugins");
showPath("Preferences");
showPath("Program");
showPath("Temporary");
showPath("User Pick");
showPath("Unknown");

showPath("Windows");
showPath("Win System");

showPath("Unix Lib");
showPath("Unix Local");

showPath("Mac Apple Menu");
showPath("Mac Control Panel");
showPath("Mac Desktop");
showPath("Mac Documents");
showPath("Mac Extension");
showPath("Mac Fonts");
showPath("Mac Preferences");
showPath("Mac Shutdown");
showPath("Mac Startup");
showPath("Mac System");
showPath("Mac Trash");

if (0 == getLastError())
   performInstall();
else
   cancelInstall();

Comment 1

[Daniel Veditz [:dveditz]]

There may be suboptimal error reporting here, but the test case is not really 
valid.  The "file:///" and "OS Drive" folders *MUST* have a second relative 
path argument in order to work, and otherwise they return null. I think your 
script is dying when showFolder() tries to getFolder(null).

OK, actually we shouldn't die in that case we should just return null again so 
I'll leave this open, but it's not the bug you think it is. I'll change the 
description and lower the severity.

Comment 2

[Henrik Lynggaard Hansen]

This bug was last changed 2000-05-24, and it has no milestone set. Is this
problem still present ? if so please verify otherwise please close this bug.

Comment 3

[David Epstein]

Test case can be triggered from
http://www.mozilla.org/quality/smartupdate/xpinstall-trigger.html
Select f_getfolder_paths(platform) from the Functional Test Case menu.

Comment 4

[Daniel Veditz [:dveditz]]

The xpinstall script engine has been removed from the trunk, bugs in it are obsolete.